Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds additional comments to warn about indexing events for rune address #56

Merged
merged 2 commits into from
Jun 3, 2024
Merged

adds additional comments to warn about indexing events for rune address #56

merged 2 commits into from
Jun 3, 2024

Conversation

0xean
Copy link
Contributor

@0xean 0xean commented Jun 3, 2024

@trust1995 recommended we add some additional documentation regarding some of the inconsistencies with the SetRuneAddress event not being fired when stake is called

NeOMakinG
NeOMakinG reviewed Jun 3, 2024
View reviewed changes
foundry/src/StakingV1.sol Outdated Show resolved Hide resolved
NeOMakinG
NeOMakinG approved these changes Jun 3, 2024
View reviewed changes
Copy link

@NeOMakinG NeOMakinG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo in one of the comments but seems legit overall, I'm not taking so much risks stamping this one 😆

@0xean
Copy link
Contributor Author

0xean commented Jun 3, 2024

thanks and fixed.

@0xean
Copy link
Contributor Author

0xean commented Jun 3, 2024

will merge once CI clears.

@0xean 0xean merged commit f80376d into main Jun 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeOMakinG NeOMakinG NeOMakinG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xean @NeOMakinG