Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rewards distribution cli improvements #55

Merged
merged 3 commits into from
May 31, 2024
Merged

chore: rewards distribution cli improvements #55

merged 3 commits into from
May 31, 2024

Conversation

woodenfurniture
Copy link
Member

Code review feedback actioned.

@0xApotheosis 0xApotheosis self-assigned this May 31, 2024
0xApotheosis
0xApotheosis requested changes May 31, 2024
View reviewed changes
Copy link
Member

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get stuck in a loop when not entering a RUNE amount:

help.mp4

@woodenfurniture
Copy link
Member Author

woodenfurniture commented May 31, 2024 •
edited
Loading

I get stuck in a loop when not entering a RUNE amount:

help.mp4

This is a limitation of the library, you need to delete the NaN text which is tricky but possible

Screen.Recording.2024-05-31.at.12.40.43.PM.mov

@woodenfurniture
Copy link
Member Author

OK @0xApotheosis I've pushed a fix to clear the input on validation error

0xApotheosis
0xApotheosis approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hack works a charm, get in!

@0xApotheosis 0xApotheosis merged commit 8367d52 into main May 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xApotheosis 0xApotheosis 0xApotheosis approved these changes

Assignees

@0xApotheosis 0xApotheosis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@woodenfurniture @0xApotheosis