Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s4585375 VQVAE OASIS #475

Open
wants to merge 13 commits into
base: topic-recognition
Choose a base branch
from

Conversation

d-soil
Copy link

@d-soil d-soil commented Oct 22, 2022

No description provided.

@d-soil d-soil marked this pull request as ready for review October 22, 2022 14:08
@SiyuLiu0329
Copy link
Collaborator

SiyuLiu0329 commented Nov 9, 2022

This is an initial inspection, no action is required at this point

  • limited documentation
  • no training logs or result visualisation
  • unable to verify code validity
  • no PR description
  • most commits done on Oct 22, 2022

@SiyuLiu0329 SiyuLiu0329 added the invalid This doesn't seem right label Nov 9, 2022
@shakes76
Copy link
Owner

Good Practice (Design/Commenting, TF/Torch Usage)

Adequate use and implementation can't verify model etc. no convergence provided -5
Good spacing and comments
Header blocks missing -1

Recognition Problem

Solves problem (no generations, results) can't verify problem solved -3
Driver Script present
File structure present
Does not Show any Usage & Demo & Visualisation & Data usage -3
Module present
Commenting
No Data leakage (no test set etc. evidence provided) -2
Difficulty: Hard

Commit Log

Meaningful commit messages
No Progressive commits used -3

Documentation

ReadMe minimal -2
Good Description and Comments
Markdown used PDF submitted

Pull Request

Successful Pull Request (Working Algorithm Delivered on Time in Correct Branch)
No Feedback required, but can't merge because no evidence of working system provided. -2
No Request Description, need to provide one -2

@shakes76 shakes76 added the Unmergeable Cant be merged for history or other reason label Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right Unmergeable Cant be merged for history or other reason VQVAE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants