Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Libs] Ngs2 #1604

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

[Libs] Ngs2 #1604

wants to merge 13 commits into from

Conversation

lzardy
Copy link
Contributor

@lzardy lzardy commented Nov 27, 2024

  • Added all ngs2 related headers
  • Reworked ngs2_impl to be more accurate, including structs (with byte comments, need confirmation)

I can remove the .cpp or .h that are not used or empty if needed.

@bigol83
Copy link
Contributor

bigol83 commented Nov 28, 2024

Is this supposed to work yet? I tried with Resident Evil and it crashes when calling the module
shad_log.txt

[Lib.SysModule] <Error> sysmodule.cpp:sceSysmoduleLoadModule:47: (DUMMY) called module = ORBIS_SYSMODULE_NGS2

@kalaposfos13
Copy link
Contributor

First off, let me state that audio in GR2 is a bit broken, and needs a skipped assert to get ingame, so it's possible that the problem comes from that, and not your PR.

Without the Ngs2 sysmodule, GR2 does output any sound, and with that on, the audio is way too loud and loopy. Here's a video showcasing it.

As the game does not go ingame on the latest main yet, I merged this PR on my gr2-hacks branch to test it. It segfaults a few seconds into booting, with the following stack trace:
hostBufferInfo is NULL here:

hostBufferInfo->hostBuffer = NULL;

called from here:
result = SystemSetup(option, bufferInfo, 0, 0);

called from the game code.

I'll attach the log as well, with the last few lines manually copied over from the terminal, as those lines got printed out to there, but not in the log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants