Update Prettier and VSCode settings, tsconfig, and app files

serifcolakel · Feb 10, 2024 · 539e78c · 539e78c
1 parent acc1a4c
commit 539e78c
Show file tree

Hide file tree

Showing 12 changed files with 43 additions and 71 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -1,7 +1,14 @@
 {
   "root": true,
   "ignorePatterns": ["**/*"],
-  "plugins": ["@nx", "react", "@typescript-eslint", "prettier", "simple-import-sort", "import"],
+  "plugins": [
+    "@nx",
+    "react",
+    "@typescript-eslint",
+    "prettier",
+    "simple-import-sort",
+    "import"
+  ],
   "extends": [
     "airbnb",
     "airbnb-typescript",
@@ -21,7 +28,7 @@
     "import/no-extraneous-dependencies": "off",
     "import/no-named-as-default": "off",
     "react/react-in-jsx-scope": "off",
-    "linebreak-style": "off",
+    "linebreak-style": "error",
     "react/jsx-props-no-spreading": "off",
     "no-console": "error",
     "no-var": "error",
@@ -139,7 +146,15 @@
           {
             "groups": [
               // Packages `react` related packages come first.
-              ["^@nx", "^react", "^\\w", "^@hookform", "^@radix-ui", "^@tanstack", "@testing-library"],
+              [
+                "^@nx",
+                "^react",
+                "^\\w",
+                "^@hookform",
+                "^@radix-ui",
+                "^@tanstack",
+                "@testing-library"
+              ],
               // npm packages
               // Anything that starts with a letter (or digit or underscore), or `@` followed by a letter.
               // ["^\\w"],
@@ -169,41 +184,6 @@
           }
         ]
       }
-    },
-    {
-      "files": ["*.ts", "*.tsx", "*.js", "*.jsx"],
-      "rules": {
-        "@nx/enforce-module-boundaries": [
-          "error",
-          {
-            "enforceBuildableLibDependency": true,
-            "allow": [],
-            "depConstraints": [
-              {
-                "sourceTag": "*",
-                "onlyDependOnLibsWithTags": ["*"]
-              }
-            ]
-          }
-        ]
-      }
-    },
-    {
-      "files": ["*.ts", "*.tsx"],
-      "extends": ["plugin:@nx/typescript"],
-      "rules": {}
-    },
-    {
-      "files": ["*.js", "*.jsx"],
-      "extends": ["plugin:@nx/javascript"],
-      "rules": {}
-    },
-    {
-      "files": ["*.spec.ts", "*.spec.tsx", "*.spec.js", "*.spec.jsx"],
-      "env": {
-        "jest": true
-      },
-      "rules": {}
     }
   ]
 }
diff --git a/.prettierrc b/.prettierrc
@@ -1,3 +1,8 @@
 {
-  "singleQuote": true
+  "tabWidth": 2,
+  "semi": true,
+  "printWidth": 80,
+  "trailingComma": "all",
+  "singleQuote": true,
+  "useTabs": false
 }
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -3,5 +3,6 @@
     "activityBar.background": "#2B3106",
     "titleBar.activeBackground": "#3C4408",
     "titleBar.activeForeground": "#F9FCE5"
-  }
+  },
+  "editor.formatOnSave": true
 }
diff --git a/apps/container/jest.config.ts b/apps/container/jest.config.ts
@@ -3,8 +3,8 @@ export default {
   preset: '../../jest.preset.js',
   transform: {
     '^(?!.*\\.(js|jsx|ts|tsx|css|json)$)': '@nx/react/plugins/jest',
-    '^.+\\.[tj]sx?$': ['babel-jest', { presets: ['@nx/react/babel'] }],
+    '^.+\\.[tj]sx?$': [ 'babel-jest', { presets: [ '@nx/react/babel' ] } ],
   },
-  moduleFileExtensions: ['ts', 'tsx', 'js', 'jsx'],
+  moduleFileExtensions: [ 'ts', 'tsx', 'js', 'jsx' ],
   coverageDirectory: '../../coverage/apps/container',
 };
diff --git a/apps/container/module-federation.config.ts b/apps/container/module-federation.config.ts
@@ -14,12 +14,10 @@ const config: ModuleFederationConfig = {
    * declare module 'my-external-remote';
    *
    */
-  remotes: [
-    ['genel-muhasebe', 'http://localhost:3005/remoteEntry.js']
-  ],
+  remotes: [],
   exposes: {
     './App': 'apps/container/src/app/app',
   },
-  };
+};
 
 export default config;
diff --git a/apps/container/project.json b/apps/container/project.json
@@ -87,14 +87,6 @@
           "buildTarget": "container:build:production"
         }
       }
-    },
-    "typecheck": {
-      "executor": "nx:run-commands",
-      "options": {
-        "commands": ["tsc -p tsconfig.app.json --noEmit"],
-        "cwd": "apps/container",
-        "forwardAllArgs": false
-      }
     }
   },
   "tags": []

diff --git a/apps/container/src/app/app.spec.tsx b/apps/container/src/app/app.spec.tsx
@@ -9,7 +9,7 @@ describe('App', () => {
     const { baseElement } = render(
       <BrowserRouter>
         <App />
-      </BrowserRouter>
+      </BrowserRouter>,
     );
 
     expect(baseElement).toBeTruthy();
@@ -19,7 +19,7 @@ describe('App', () => {
     const { getByText } = render(
       <BrowserRouter>
         <App />
-      </BrowserRouter>
+      </BrowserRouter>,
     );
 
     expect(getByText(/Welcome container/gi)).toBeTruthy();

diff --git a/apps/container/src/app/nx-welcome.tsx b/apps/container/src/app/nx-welcome.tsx
@@ -1,3 +1,4 @@
+/* eslint-disable max-len */
 /* eslint-disable react/no-danger */
 /*
  * * * * * * * * * * * * * * * * * * * * * * * * * * * *
@@ -7,7 +8,6 @@
  * * * * * * * * * * * * * * * * * * * * * * * * * * * *
  */
 export function NxWelcome({ title }: { title: string }) {
-
   return (
     <>
       <style

diff --git a/apps/container/src/bootstrap.tsx b/apps/container/src/bootstrap.tsx
@@ -5,13 +5,13 @@ import { BrowserRouter } from 'react-router-dom';
 import App from './app/app';
 
 const root = ReactDOM.createRoot(
-  document.getElementById('root') as HTMLElement
+  document.getElementById('root') as HTMLElement,
 );
 
 root.render(
   <StrictMode>
     <BrowserRouter>
       <App />
     </BrowserRouter>
-  </StrictMode>
+  </StrictMode>,
 );
diff --git a/apps/container/webpack.config.prod.ts b/apps/container/webpack.config.prod.ts
@@ -1,6 +1,6 @@
 import { withReact } from '@nx/react';
 import { withModuleFederation } from '@nx/react/module-federation';
-import { composePlugins, ModuleFederationConfig,withNx  } from '@nx/webpack';
+import { composePlugins, ModuleFederationConfig, withNx } from '@nx/webpack';
 
 import baseConfig from './module-federation.config';
 
@@ -24,13 +24,13 @@ const prodConfig: ModuleFederationConfig = {
    * ]
    */
   remotes: [
-    ['genel-muhasebe', 'http://localhost:3005/remoteEntry.js']
-  ]
+    [ 'genel-muhasebe', 'http://localhost:3005/remoteEntry.js' ],
+  ],
 };
 
 // Nx plugins for webpack to build config object from Nx options and context.
 export default composePlugins(
   withNx(),
   withReact(),
-  withModuleFederation(prodConfig)
+  withModuleFederation(prodConfig),
 );
diff --git a/apps/container/webpack.config.ts b/apps/container/webpack.config.ts
@@ -1,6 +1,6 @@
 import { withReact } from '@nx/react';
 import { withModuleFederation } from '@nx/react/module-federation';
-import { composePlugins, ModuleFederationConfig,withNx } from '@nx/webpack';
+import { composePlugins, ModuleFederationConfig, withNx } from '@nx/webpack';
 
 import baseConfig from './module-federation.config';
 
@@ -14,6 +14,6 @@ export default composePlugins(
   withReact(),
   withModuleFederation(config),
   (oldConfig) => ({
-      ...oldConfig,
-    })
+    ...oldConfig,
+  }),
 );
diff --git a/tsconfig.base.json b/tsconfig.base.json
@@ -16,11 +16,7 @@
     "jsx": "react",
     "downlevelIteration": true,
     "target": "es6",
-    "lib": [
-      "dom",
-      "dom.iterable",
-      "esnext"
-    ],
+    "lib": ["dom", "dom.iterable", "esnext"],
     "baseUrl": ".",
     "paths": {
       "genel-muhasebe/Module": ["apps/genel-muhasebe/src/remote-entry.ts"]