This repository has been archived by the owner on Jan 2, 2025. It is now read-only.
Commentary API Backend #1542
Closed
Commentary API Backend #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burdiyan
force-pushed
the
feat/commenting-api-proto
branch
from
1e5db4f to
fe20023
Compare
burdiyan
force-pushed
the
feat/commenting-api-proto
branch
from
fe20023 to
665b43b
Compare
burdiyan
force-pushed
the
feat/commenting-api-proto
branch
from
665b43b to
7a3ce9c
Compare
|
Work continues in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the commentary API.
Ended up having separate calls for creating initial comments (only supports versioned document links now), from creating replies. The reason for that is to make it less error-prone as to what target should be used in replies. Especially because the semantics of this regarding to updating comments are unclear. This way when we introduce updates, the frontend wouldn't need to change this part probably.
I've been researching various APIs that do comments, like YouTube, Google Docs, Notion, etc. And some of them have this distinction between replies and comments, and I figured it could be helpful.