'nother planning graph fix check interference in both directions

sdcondon · Dec 16, 2022 · e9963bd · e9963bd
1 parent e79cb5c
commit e9963bd
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/src/SCClassicalPlanning/Planning/GraphPlan/PlanningGraph.cs b/src/SCClassicalPlanning/Planning/GraphPlan/PlanningGraph.cs
@@ -282,8 +282,10 @@ private void MakeNextLevel()
             {
                 foreach (var (otherAction, otherActionNode) in newActionLevel.Take(actionIndex))
                 {
+                    // todo-performance: at first glance looks like we can do with with just one check (union effect and precond..)?
                     if (otherAction.Effect.Elements.Overlaps(action.Effect.Elements.Select(l => l.Negate())) // inconsistent effects
                         || otherAction.Effect.Elements.Overlaps(action.Precondition.Elements.Select(l => l.Negate())) // interference
+                        || otherAction.Precondition.Elements.Overlaps(action.Effect.Elements.Select(l => l.Negate())) // interference the other way around
                         || otherAction.Precondition.Elements.Overlaps(action.Precondition.Elements.Select(l => l.Negate()))) // competing needs
                     {
                         actionNode.Mutexes.Add(otherActionNode);