Skip to content

Commit

Permalink
Audit Fixes EIP2930/1559 in RLP Circuits (#1175)
Browse files Browse the repository at this point in the history
* Correct typo

* Correct RLC

* Change tag column status

* Add tx_nonce consistency

* Remove vestige gadget

* Add v constraint for 1559/2930

* Constrain depth consistency for fsm state transition

* Correct q_first query for initial num_all_txs_acc condition

* Ensure continuity of sectional flag is_calldata and is_access_list

* Remove tx unchanged constraint for dynamic sectional transition

* Add tx_id constraints in dynamic section

* Constrain access list tx table fields according to AccessListAddressLen

* Constrain is_padding_tx

* Add constraint for id calculation in rlp_decoding_table

* Remove redundant boolean requirements

* Add init condition for access_list_idx and storage_key_idx

* Turn on value_is_zero for access list len

* Remove whitespace

* Add byte_idx to PUSH/POP lookup correspondence

* fmt

* Update cargo

* Resolve build issues

* fmt and clippy

* Recover tests

* Correct gate name

* Remove debug flags

* fmt

* cargo

* Revert ethers-core branch

* cargo

* Restrict booleans

* fmt

* Audit Fixes EIP2930/1559 RLP Decoding Table Correspondence (#1181)

* Remove debug flags

* Add decoding table PUSH lookup correspondence

* Complete Stack Op Correspondence

* fmt

* Correct lookup constraint

* Remove unused macro

* fmt

* Correct lookup constraint for pre 2930 txs

* fmt

* Adjust comments

* fmt

* Add lookup indicator column for state machine

* Add correct condition for stack op lookups

* Complete PUSH op lookup

* Correct POP op lookup

* Correct PUSH lookup

* fmt

* Add backward compatibility for eip155 and pre155

* Add al_idx to input expression

* Add access list idx to PUSH correspondence

---------

Co-authored-by: DreamWuGit <wwuwwei@126.com>

* Audit Fixes EIP2930/1559 TxCircuit Dynamic Section Transitions (#1176)

* Refactor tx circuit dynamic section after introducing access list

* Adjust comments

* fmt

* Column naming

---------

Co-authored-by: DreamWuGit <wwuwwei@126.com>

---------

Co-authored-by: DreamWuGit <wwuwwei@126.com>
Co-authored-by: Zhang Zhuo <mycinbrin@gmail.com>
  • Loading branch information
3 people authored Apr 24, 2024
1 parent a487780 commit ceba59e
Show file tree
Hide file tree
Showing 5 changed files with 897 additions and 461 deletions.
Loading

0 comments on commit ceba59e

Please sign in to comment.