Skip to content

Commit

Permalink
Fix: tx circuit errors (#1303)
Browse files Browse the repository at this point in the history
* fix next_tx

* remove wrong constraints
  • Loading branch information
kunxian-xia authored May 29, 2024
1 parent 715a0c3 commit c0294ac
Showing 1 changed file with 1 addition and 12 deletions.
13 changes: 1 addition & 12 deletions zkevm-circuits/src/tx_circuit.rs
Original file line number Diff line number Diff line change
Expand Up @@ -923,17 +923,6 @@ impl<F: Field> SubCircuitConfig<F> for TxCircuitConfig<F> {
},
);

// AccessListAddressLen != 0 must force AccessListRLC != 0
cb.condition(
and::expr([
is_access_list_addresses_len(meta),
not::expr(meta.query_advice(is_none, Rotation::cur())),
]),
|cb| {
cb.require_zero("AccessListRLC != 0", value_is_zero.expr(Rotation(2))(meta));
},
);

cb.gate(meta.query_fixed(q_enable, Rotation::cur()))
});

Expand Down Expand Up @@ -4323,7 +4312,7 @@ impl<F: Field> TxCircuit<F> {
.txs
.iter()
.skip(i + 1)
.find(|tx| !tx.call_data.is_empty());
.find(|tx| !tx.call_data.is_empty() || (tx.access_list.as_ref().map_or(false, |al| !al.0.is_empty())));
config.assign_calldata_rows(
&mut region,
&mut offset,
Expand Down

0 comments on commit c0294ac

Please sign in to comment.