adjust Value.ignore() to make ignoring of other types than String available #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilable
Sometimes we have a JDBC Row where 0 value means "null" but ignoring does only work with strings until now.
object.as(Row.class).getValue("value").ignore(BigDecimal.ZERO) should ignore a found 0 without calling
Value.of(object.as(Row.class).getValue().asString().ignore("0")
idlira
approved these changes
Aug 14, 2024
sabieber
approved these changes
Aug 14, 2024
sabieber
approved these changes
Aug 14, 2024
fhaScireum
approved these changes
Aug 15, 2024
bkositza
approved these changes
Aug 15, 2024
jmuscireum
approved these changes
Aug 15, 2024
ymo-sci
added
the
💣 BREAKING CHANGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes we have a JDBC Row where 0 value means "null" but ignoring does only work with strings until now.
object.as(Row.class).getValue("value").ignore(BigDecimal.ZERO)should ignore a found 0 without calling castedValue.of(object.as(Row.class).getValue().asString()).ignore("0")Additional Notes
Checklist