Skip to content
This repository has been archived by the owner on Nov 29, 2020. It is now read-only.

Sonatype publishing. #36

Closed
wants to merge 8 commits into from
Closed

Sonatype publishing. #36

wants to merge 8 commits into from

Conversation

sir-wabbit
Copy link
Contributor

No description provided.

@NeQuissimus
Copy link
Member

A few questions :D

  1. Why Bintray over Sonatype?
  2. What repo do the artifacts end up in?
  3. Do you not have to tell Travis to actually do the publishing?

@sir-wabbit
Copy link
Contributor Author

sir-wabbit commented Jul 7, 2018 •
edited
Loading

All great questions. This is just temporary solution to my lack of sonatype credentials. I would prefer sonatype, but I have no idea how to set it up. For now I am publishing to https://bintray.com/alexknvl/maven. Travis doesn't have my credentials and I don't have enough permissions on Travis to change that... 😄 I'll update the README with a link to the repo.

@sir-wabbit
Copy link
Contributor Author

Actually, I don't even need this in master (the plugin part), since I am publishing locally anyway. Still, it's nice to have some published artifacts in README (+license and artifact names), even if it is temporary. There might be problems because scalaz-meta is also an artifact name in scalaz 8.

hrhino
hrhino approved these changes Jul 8, 2018
View reviewed changes
README.md Outdated
```scala
resolvers += Resolver.bintrayRepo("alexknvl", "maven"),
libraryDependencies += "org.scalaz" %% "scalaz-plugin-library" % "77dd9707",
addCompilerPlugin("org.scalaz" % "scalaz-plugin_2.12.6" % "77dd9707")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should replace this with "<git-hash>" or something, unless you intend to update this often.

Also, use cross CrossVersion.full rather than _2.12.6?

build.sbt
@@ -8,12 +8,14 @@ addCompilerPlugin("org.scalamacros" % "paradise" % "2.1.0" cross CrossVersion.fu
scalacOptions ++= List("-Xplugin-require:macroparadise")

lazy val meta = crossProject.module
.settings(stdSettings("meta"))
.settings(stdSettings("plugin-library"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@NeQuissimus
Copy link
Member

In .travis.yml, replace the existing secrets with these

+  - secure: MnKEc3GKeg/mx+gRA/lsVkcV/hSCls3/5ilq5pNq4JYd3JuEk8i3U56BkwNzFQowZztRKrS1KlgAI3nNWzpFTDPmCvC/feuKIOVHd3CRuezPQh5jitAAc/cLPALKakDuwMnU4bqdDWR59sJi4oYTt05n7lWnJDXPGo7rHraHiZ/bCPrJ5hvxxGPMAFCeQHFD0C1YEl8GTFtGBmGrSk6fU6sIpzp3a+T2/iXXBm6B8hqpwcUh1IENWW1Z40qqds7kwH2OY3FEIO9eDoB+BUdnDR6uTqgMwF6owWK2pQH/mEDIlEvB8TVVpSnAyp5wxzx9WNAxc0FRWkqtYXk9DiX4ScV0ACd4/thqbDM4QqCLkrxlLHWlRXfELdmhhHgkaz/bAnAPt7gR3B7ujrOFvBso24Zjf0jzmh0enUkYZzsV3wRq5D8Gpy9JEeTtKUCQQnLScb5M0bLCvmea3i3sNDF+EvuWvoo/3SdfES4qn0KH32JIz6Jb/80RRMx8cpBpxWhmoKd1QUCNszQR33MhM7xwjwfdtKGxs6/qTFF2+cKbxJf0CDCFijrSyANs+oB5J+D2dHOY4c0PjyP4zO6EGZNasDPN0lK2zV3ejtKUekfeWc2oToSu2e9HVPpSiR0AOmfeVkCY86CY0rSadbvEqoL+JJKFN0NQsC7GYsyo8XcZDfI=
+  - secure: UnbvLVfOIVrovJXLD9NaIyUqjK6Ntyh6lRjUDHm5zzMtQx0MUvbtPGdrsxPDPaE7Y2u0Nl05AS7LyrEY37vBro0vOhLJiVBHwL2y4MzSF+YHwlqeY3rkZXcNgPG4QTudlbsndcFLi0eY13TZMcqEfI948/HKbvX11oBJGIWNs0EOiH5WabTj5jIQ6Xh+SXAC6E6WOLx0fgqfPjBQDTvXvZBgV7ejwRJfuvynL2Evco0GWBQ3yBA7+p6knNrfz9LPs2hcFrC2rxE91rNnm/pjUKu08E8ZEJGyfO1v//rqH30Qt2KYWQd35ELWSIMUQHSWpBO5sQ84GAKArOt/txlo/4wfWkBwhVA3whp/PCXIUqpftfvLGiorW/eXNGFdeR9VORvRlGzLp3kpfMN7keyv3tgwFw3S231hYiRG+IraUhdLz/sHCZ47oFpWWS7EBs14VON3kHHX02HS7/EpcbUiM2fwq1QClqRX5DJ7wOz+m5a9LIdmwY2Y8+eBlck6nZjDm0ZMbTj36yeDD4sbLOXySE0hJGlyuo1uugdZUitE55itmRyFSyoLETjK/TQOyarG1P+WpDUxRpEfofyojn4WKWJ2m2Uj52Ne19Uvl1NPWbh/oJf484pf7/FChovhVNp/wd6XzFof+tloZL3gCpcOPqsr+/EwToOAf2ixPEaupLY=

If you then take the sonatype publishing stuff from scalaz/scalaz, you should be able to push artifacts for this repo.

@sir-wabbit sir-wabbit changed the title Bintray publishig. Bintray publishing. Aug 13, 2018
@sir-wabbit sir-wabbit changed the title Bintray publishing. Sonatype publishing. Aug 13, 2018
@sir-wabbit sir-wabbit requested a review from NeQuissimus August 13, 2018 04:49
@NeQuissimus
Copy link
Member

Provided you have the rest locally and intend to keep it there, this is OK. Otherwise, check zio/zio#172

@NeQuissimus
Copy link
Member

@alexknvl Do you want me to take a look at this and maybe redo it? I would like to try this plugin in one of my projects and some sort of tagged release would be nice :)

@sir-wabbit
Copy link
Contributor Author

sir-wabbit commented Aug 30, 2018 •
edited
Loading

Sure, go ahead.

EDIT: Just make a new pull request, I'll close this one.

@NeQuissimus
Copy link
Member

Sounds good, give me a few days.
I will likely have to create tags to test things, should I go with v0.0.x ?

@sir-wabbit
Copy link
Contributor Author

Yeah, sounds good. I think we'll do v1.0.0 once #23 is fixed (or we make it opt-in rather than opt-out).

@NeQuissimus NeQuissimus self-assigned this Aug 30, 2018
@NeQuissimus NeQuissimus closed this Sep 5, 2018
@NeQuissimus NeQuissimus deleted the feature/bintray-publishing branch September 5, 2018 01:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hrhino hrhino hrhino approved these changes

@NeQuissimus NeQuissimus Awaiting requested review from NeQuissimus

Assignees

@NeQuissimus NeQuissimus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sir-wabbit @NeQuissimus @hrhino @beer-avalanche