Update ruby to 3.1.2 [Deployment scheduled Thursday @5pm] #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenTopping
reviewed
Jan 26, 2024
| @@ -14,7 +14,7 @@ def down | |||
| t.remove :pac_bio_library_tube_barcode | |||
| end | |||
| # Here we add a placeholder value in case any plate barcodes were added as null since the migration | |||
| PacBioRun.where(plate_barcode: nil).each do |run| | |||
There was a problem hiding this comment.
I would add 'db/migrate/*' to the rubocop ignore list as we don't need to bother updating old migrations.
There was a problem hiding this comment.
Agreed. I will leave the change but add it to the gitignore.
This is concerning. It means we don't have enough coverage as this is not immediately obvious that it needs changing but would cause a breaking change. |
yoldas
previously approved these changes
Jan 26, 2024
BenTopping
approved these changes
Jan 26, 2024
stevieing
changed the title
stevieing
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Changes proposed in this pull request
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version