Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rubocop-rspec 2.23.0 → 2.24.1 (minor) #556

Closed
wants to merge 1 commit into from
Closed

Update rubocop-rspec 2.23.0 → 2.24.1 (minor) #556

wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Sep 24, 2023

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rspec (2.23.0 → 2.24.1) · Repo · Changelog

Release Notes

2.24.1

  • Fix an error when using RSpec/FilePath and revert to enabled by default. If you have already moved to RSpec/SpecFilePathSuffix and RSpec/SpecFilePathFormat, disable RSpec/FilePath explicitly as Enabled: false. The RSpec/FilePath before migration and the RSpec/SpecFilePathSuffix and RSpec/SpecFilePathFormat as the target are available respectively. (@ydah)

2.24.0

  • Split RSpec/FilePath into RSpec/SpecFilePathSuffix and RSpec/SpecFilePathFormat. RSpec/FilePath cop is enabled by default, the two new cops are pending and need to be enabled explicitly. (@ydah)
  • Add new RSpec/Eq cop. (@ydah)
  • Add RSpec/MetadataStyle and RSpec/EmptyMetadata cops. (@r7kamura)
  • Add support RSpec/Rails/HttpStatus when have_http_status with string argument. (@ydah)
  • Fix an infinite loop error when RSpec/ExcessiveDocstringSpacing finds a description with non-ASCII leading/trailing whitespace. (@bcgraham)
  • Fix an incorrect autocorrect for RSpec/ReceiveMessages when return values declared between stubs. (@marocchino)
  • Fix a false positive RSpec/Focus when chained method call and inside define method. (@ydah)

2.23.2

  • Fix an incorrect autocorrect for RSpec/ReceiveMessages when method is only non-word character. (@marocchino)
  • Fix a false positive for RSpec/ReceiveMessages when return with splat. (@marocchino)

2.23.1

  • Mark to Safe: false for RSpec/Rails/NegationBeValid cop. (@ydah)
  • Declare autocorrect as unsafe for RSpec/ReceiveMessages. (@bquorning)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 50 commits:

✳️ rubocop (1.55.1 → 1.56.3) · Repo · Changelog

Release Notes

1.56.3

Bug fixes

  • #12151: Make Layout/EmptyLineAfterGuardClause allow :nocov: directive after guard clause. (@koic)
  • #12195: Fix a false negative for Layout/SpaceAfterNot when a newline is present after !. (@ymap)
  • #12192: Fix a false positive for Layout/RedundantLineBreak when using quoted symbols with a single newline. (@ymap)
  • #12190: Fix a false positive for Layout/SpaceAroundOperators when aligning operators vertically. (@koic)
  • #12171: Fix a false positive for Style/ArrayIntersect when using block argument for Enumerable#any?. (@koic)
  • #12172: Fix a false positive for Style/EmptyCaseCondition when using return, break, next or method call before empty case condition. (@koic)
  • #12162: Fix an error for Bundler/DuplicatedGroup when there's a duplicate set of groups and the group value contains a splat. (@koic)
  • #12182: Fix an error for Lint/UselessAssignment when variables are assigned using chained assignment and remain unreferenced. (@koic)
  • #12181: Fix an incorrect autocorrect for Lint/UselessAssignment when variables are assigned with sequential assignment using the comma operator and unreferenced. (@koic)
  • #12187: Fix an incorrect autocorrect for Style/SoleNestedConditional when comment is in an empty nested if body. (@ymap)
  • #12183: Fix an incorrect autocorrect for Style/MultilineTernaryOperator when returning a multiline ternary operator expression with safe navigation method call. (@koic)
  • #12168: Fix bug in Style/ArgumentsForwarding when there are repeated send nodes. (@owst)
  • #12185: Set target version for Layout/HeredocIndentation. (@tagliala)

1.56.2

Bug fixes

  • #12138: Fix a false positive for Layout/LineContinuationLeadingSpace when a backslash is part of a multiline string literal. (@ymap)
  • #12155: Fix false positive for Layout/RedundantLineBreak when using a modified singleton method definition. (@koic)
  • #12143: Fix a false positive for Lint/ToEnumArguments when using anonymous keyword arguments forwarding. (@koic)
  • #12148: Fix an incorrect autocorrect for Lint/NonAtomicFileOperation when using FileUtils.remove_dir, FileUtils.remove_entry, or FileUtils.remove_entry_secure. (@koic)
  • #12141: Fix false positive for Style/ArgumentsForwarding when method def includes additional kwargs. (@owst)
  • #12154: Fix incorrect diagnosticProvider value of LSP. (@koic)

1.56.1

Bug fixes

  • #12136: Fix a false negative for Layout/LeadingCommentSpace when using #+ or #- as they are not RDoc comments. (@koic)
  • #12113: Fix a false positive for Bundler/DuplicatedGroup when groups are duplicated but source, git, platforms, or path values are different. (@koic)
  • #12134: Fix a false positive for Style/MethodCallWithArgsParentheses when parentheses are used in one-line in pattern matching. (@koic)
  • #12111: Fix an error for Bundler/DuplicatedGroup group declaration has keyword option. (@koic)
  • #12109: Fix an error for Style/ArgumentsForwarding cop when forwarding kwargs/block arg and an additional arg. (@ydah)
  • #12117: Fix a false positive for Style/ArgumentsForwarding cop when not always forwarding block. (@owst)
  • #12115: Fix an error for Style/Lambda when using numbered parameter with a multiline -> call. (@koic)
  • #12124: Fix false positives for Style/RedundantParentheses when parentheses in super or yield call with multiline style argument. (@koic)
  • #12120: Fix false positives for Style/SymbolArray when %i array containing unescaped [, ], (, or ). (@koic)
  • #12133: Fix Style/RedundantSelfAssignmentBranch to handle heredocs. (@r7kamura)
  • #12105: Fix target ruby Gem::Requirement matcher and version parsing to support multiple version constraints. (@ItsEcholot)

1.56.0

New features

  • #12074: Add new Bundler/DuplicatedGroup cop. (@OwlKing)
  • #12078: Make LSP server support rubocop.formatAutocorrectsAll execute command. (@koic)

Bug fixes

  • #12106: Fix a false negative for Style/RedundantReturn when returning value with guard clause and return is used. (@koic)
  • #12095: Fix a false positive for Style/Alias when EncforcedStyle: prefer_alias and using alias with interpolated symbol argument. (@koic)
  • #12098: Fix a false positive for Style/ClassEqualityComparison when comparing interpolated string class name for equality. (@koic)
  • #12102: Fix an error for Style/LambdaCall when using nested lambda call x.().(). (@koic)
  • #12099: Fix an incorrect autocorrect for Style/Alias when EncforcedStyle: prefer_alias_method and using alias with interpolated symbol argument. (@koic)
  • #12085: Fix an error for Lint/SuppressedException when AllowNil: true is set and endless method definition is used. (@koic)
  • #12087: Fix false positives for Style/ArgumentsForwarding with additional args/kwargs in def/send nodes. (@owst)
  • #12071: Fix Style/SymbolArray false positives when using square brackets or interpolation in a symbol literal in a percent style array. (@jasondoc3)
  • #12061: Support regex in StringLiteralsInInterpolation. (@jonas054)
  • #12091: With --fail-level A ignore non-correctable offenses at :info severity. (@naveg)

Changes

  • #12094: Add base64 gem to runtime dependency to suppress Ruby 3.3's warning. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ rubocop-capybara (indirect, 2.18.0 → 2.19.0) · Repo · Changelog

Release Notes

2.19.0

What's Changed

  • Add new Capybara/RSpec/PredicateMatcher cop. (@ydah)
  • Add new Capybara/RSpec/HaveSelector cop. (@ydah)
  • Add new Capybara/ClickLinkOrButtonStyle cop. (@ydah)
  • Fix a false positive for Capybara/SpecificFinders when find with kind option. (@ydah)
  • Fix an incorrect autocorrect for Capybara/CurrentPathExpectation. (@ydah)
  • Drop Ruby 2.6 support. (@ydah)

Full Changelog: v2.18.0...v2.19.0

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 36 commits:

↗️ rubocop-factory_bot (indirect, 2.23.1 → 2.24.0) · Repo · Changelog

Release Notes

2.24.0

What's Changed

  • Fix FactoryBot/AssociationStyle cop to ignore explicit associations with strategy: :build. (@pirj)
  • Change FactoryBot/CreateList so that it is not an offense if not repeated multiple times. (@ydah)
  • Fix a false positive for FactoryBot/AssociationStyle when association is called in trait block and column name is keyword. (@ydah)
  • Fix a false positive for FactoryBot/AssociationStyle when EnforcedStyle: Explicit and using trait within trait. (@ydah)
  • Change FactoryBot/AssociationStyle, FactoryBot/AttributeDefinedStatically, FactoryBot/CreateList and FactoryBot/FactoryClassName to work with minitest style directory. (@ydah)
  • Add FactoryBot/IdSequence cop. (@owst)

Full Changelog: v2.23.1...v2.24.0

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 26 commits:

🆕 base64 (added, 0.1.1)

Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Sep 24, 2023
@depfu depfu bot mentioned this pull request Sep 24, 2023
Closed
@depfu
Copy link
Contributor Author

depfu bot commented Oct 28, 2023

Closed in favor of #562.

@depfu depfu bot closed this Oct 28, 2023
@depfu depfu bot deleted the depfu/update/rubocop-rspec-2.24.1 branch October 28, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
depfu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0 participants