Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-518 - SMRTLink v25.1 Revio support #1515

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

BenTopping
Copy link
Collaborator

@BenTopping BenTopping commented Jan 7, 2025

Closes #1510

Changes proposed in this pull request

  • Adds v25_1_revio SMRTLink option.
  • Adds pacbio_sample_sheet_v25 to handle well settings uniquely for the v25_1_revio sample sheets.
  • Adds use_adaptive_loading and full_resolution_base_qual smrt link options.
  • Adds custom smrt link option validator to handle use_adaptive_loading constraint to be the same for all wells in a run.

Reviewer notes

Not sure if the custom smrt link option validator is the best option or not. The requirement is to ensure all v13 > revio runs using use_adaptive_loading have a consistent value across the run - all True or all False. So this validation is a mix of instrument type, smrt link option, run and well validation.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.98%. Comparing base (240680f) to head (1854433).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1515      +/-   ##
===========================================
+ Coverage    97.95%   97.98%   +0.02%     
===========================================
  Files          426      430       +4     
  Lines        13514    13685     +171     
===========================================
+ Hits         13238    13409     +171     
  Misses         276      276              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant