add new grid direction

[sabrine33]

No description provided.

[khelwood]

How is DownLeft direction related to a 180º rotation?

[sabrine33]

How is DownLeft direction related to a 180º rotation?

I found the naming a bit confusing. I tried to align the logic with the existing names, which made sense to me at some point. There are additional details on the client side, but I’m happy to discuss this further if it’s still unclear.

[khelwood]

@sabrine33 Going by this code in client:

case GridDirection.DownLeft:
      // Reverse row-major order (bottom to top, right to left) // Rotate 180 degrees
      for (let row = numRows; row >= 1; row--) {
        for (let col = numColumns; col >= 1; col--) {
          addresses.push(createAddress(row, col));
        }
      }
      break;

this direction should be named LeftUp. From the starting position, to get to the next slots you go Left, and when you've gone all the way left you move Up.

If it's possible to support this requirement in the client without altering core.GridDirection, that might be better. core.GridDirection is coupled to the GridDirection used by storage locations in Storelight.

[sabrine33]

@sabrine33 Going by this code in client:

case GridDirection.DownLeft:
      // Reverse row-major order (bottom to top, right to left) // Rotate 180 degrees
      for (let row = numRows; row >= 1; row--) {
        for (let col = numColumns; col >= 1; col--) {
          addresses.push(createAddress(row, col));
        }
      }
      break;

this direction should be named LeftUp. From the starting position, to get to the next slots you go Left, and when you've gone all the way left you move Up.

If it's possible to support this requirement in the client without altering core.GridDirection, that might be better. core.GridDirection is coupled to the GridDirection used by storage locations in Storelight.

Thank you! I will update the PR and decouple it from the core, I was not aware that this is mainly for storlight