Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metadatable type in poly_metadata relationship on Well #4582

Conversation

yoldas
Copy link
Member

@yoldas yoldas commented Jan 6, 2025

Closes #

Changes proposed in this pull request

  • Overrides the autogenerated poly_metadata method to pick the type correctly

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

@yoldas yoldas changed the base branch from develop to migrating-to-number-of-pools-epic January 6, 2025 10:01
@yoldas yoldas changed the title Fix metadatable type in polymetadata relationship Fix metadatable type in poly_metadata relationship on Well Jan 6, 2025
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.31%. Comparing base (b010f3a) to head (86a6c10).
Report is 2 commits behind head on migrating-to-number-of-pools-epic.

Files with missing lines Patch % Lines
app/models/well.rb 66.66% 1 Missing ⚠️
Additional details and impacted files
@@                          Coverage Diff                          @@
##           migrating-to-number-of-pools-epic    #4582      +/-   ##
=====================================================================
+ Coverage                              89.29%   89.31%   +0.02%     
=====================================================================
  Files                                   1407     1407              
  Lines                                  30181    30185       +4     
=====================================================================
+ Hits                                   26950    26961      +11     
+ Misses                                  3231     3224       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yoldas yoldas merged commit 1bd3ea4 into migrating-to-number-of-pools-epic Jan 6, 2025
24 of 25 checks passed
@yoldas yoldas deleted the fix-metadatable-type-in-polymetadata-relationship branch January 6, 2025 11:14
@yoldas yoldas self-assigned this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants