Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24 103 tuberack presenter tube labels #4581

Merged

Conversation

andrewsparkes
Copy link
Member

Closes #

Changes proposed in this pull request

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

@andrewsparkes andrewsparkes changed the base branch from develop to y24-088-tuberacks-epic January 3, 2025 16:50
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.25%. Comparing base (f3e46d2) to head (5d01699).
Report is 8 commits behind head on y24-088-tuberacks-epic.

Additional details and impacted files
@@                    Coverage Diff                     @@
##           y24-088-tuberacks-epic    #4581      +/-   ##
==========================================================
+ Coverage                   87.15%   89.25%   +2.09%     
==========================================================
  Files                        1411     1410       -1     
  Lines                       30180    30137      -43     
==========================================================
+ Hits                        26303    26898     +595     
+ Misses                       3877     3239     -638     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

app/models/tube_rack.rb Outdated Show resolved Hide resolved
Copy link
Member

@yoldas yoldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@andrewsparkes andrewsparkes merged commit 8eb2269 into y24-088-tuberacks-epic Jan 8, 2025
25 checks passed
@andrewsparkes andrewsparkes deleted the y24-103-tuberack-presenter-tube-labels branch January 8, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tube Racks - Check Print Tube labels button in Rack Presenter
2 participants