Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

007c fix - manifest tweaks #4532

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Conversation

KatyTaylor
Copy link
Contributor

@KatyTaylor KatyTaylor commented Dec 2, 2024

Closes #

Changes proposed in this pull request

  • Change number of samples per pool to allow for larger pools, based on predicted samples coming through
  • Add extra columns to manifest - info that is needed for data release
  • (Feedback from Abby & Liz H in Slack)

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.13%. Comparing base (2529221) to head (4ed56ca).
Report is 8 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4532      +/-   ##
===========================================
+ Coverage    89.10%   89.13%   +0.03%     
===========================================
  Files         1392     1392              
  Lines        29830    29830              
===========================================
+ Hits         26581    26590       +9     
+ Misses        3249     3240       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KatyTaylor KatyTaylor changed the title 007c fix - higher number of samples per pool in manifest 007c fix - manifest tweaks Dec 3, 2024
@KatyTaylor KatyTaylor linked an issue Dec 3, 2024 that may be closed by this pull request
2 tasks
Copy link
Member

@yoldas yoldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes:

I think the row_per_well value 120 arbitrary, just to get a higher number of samples, but it looks like a magic number.

The spreadsheet will be very long.

date_of_sample_collection and sample_ebi_accession_number is mapped to headings in spec/data/sample_manifest_excel/columns.yml as DATE OF SAMPLE COLLECTION and SAMPLE ACCESSION NUMBER (optional) respectively.

@KatyTaylor KatyTaylor marked this pull request as ready for review December 3, 2024 14:52
@KatyTaylor KatyTaylor merged commit 43ca25d into develop Dec 4, 2024
25 checks passed
@KatyTaylor KatyTaylor deleted the scRNA-core-pools-manifest-fix branch December 4, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Y24-493 - Add additional columns to 007c pools manifest
2 participants