Y24-181 - Clean up HiSeq submission templates #4232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4232 +/- ##
===========================================
+ Coverage 86.74% 87.41% +0.67%
===========================================
Files 1369 1369
Lines 29746 29600 -146
===========================================
+ Hits 25802 25876 +74
+ Misses 3944 3724 -220 ☔ View full report in Codecov by Sentry. |
|
Code cov doesn't seem too happy with this but the behaviour is tested. I think because we are testing the output of the rake task rather than the internals it is not correctly identifying which parts have been tested. |
KatyTaylor
reviewed
Jul 31, 2024
KatyTaylor
reviewed
Jul 31, 2024
KatyTaylor
reviewed
Jul 31, 2024
BenTopping
force-pushed
the
Y24-181-clean-up-hiseq-submission-templates
branch
from
649f537 to
cb446cf
Compare
…on templates in seed data
…r and updates tests
- Updates disable hiseq submission rake task to ignore already superceded templates
…y with existing templates
BenTopping
force-pushed
the
Y24-181-clean-up-hiseq-submission-templates
branch
from
aaba17f to
2446b5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4189
Changes proposed in this pull request