Release Y24-052 [BUG] Dropdown list dependencies #4088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ta release 'strategy' and 'timing' fields - add 'validates' methods on study metadata - add constant for 'immediate' timing to study, following existing pattern - add tests for the new validation - amend existing tests that were creating invalid data
- They enforce the relationship between data release strategy and timing that is required by the Study creation and edit UI
…date Y24-028 Targeted NanoSeq - added filters on polymetadata resource
…2-BUG-Dropdown-list-dependencies
Fix task loading for rake test
[ruby] Update nokogiri 1.16.2 → 1.16.4 (patch)
🚨 [security] [js] Update vite 5.1.5 → 5.1.7 (patch)
- the JS inside the legacy_javascript_tag in _related_fields.html.erb wasn't running at all, when rendered on the admin studies edit page - this was because the page was already loaded, so the event listener never heard the 'DOMContentLoaded' event - the page was already loaded because the edit page is rendered inside the index page, only after a value is selected from the dropdown list of studies - add an 'if' statement in the legacy javascript tag to check if the page is still loading before listening for the event - if the page is not still loading, just render the contents without waiting for the event
[ruby] Update json 2.7.1 → 2.7.2 (patch)
- there is a lot of existing data that would trigger this validation currently - flag this off until the data is fixed - improve tests - add tests for when the feature flag is on and when it is off
…2-BUG-Dropdown-list-dependencies
…encies Y24-052 [BUG] Dropdown list dependencies
sdjmchattie
approved these changes
Apr 22, 2024
stevieing
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Changes proposed in this pull request
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version