Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruby] Update carrierwave 3.0.5 → 3.0.6 (patch) #4053

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Mar 11, 2024

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ carrierwave (3.0.5 → 3.0.6) · Repo · Changelog

Release Notes

3.0.6

Fixed

  • Fix #derived_versions and #active_sibling_versions returning an Array where Hash is expected (@mshibuya 46e4f20)
  • Fix incompatibility with Marcel 1.0.3 (@schinery #2728, #2729)
  • Fix assigning a file with the same name not marking the column as changed (@mshibuya 4c65b39, #2719)
  • Fix failing to remove files with ActiveRecord 7.1 after_commit order change enabled (@mshibuya 63113e9, #2713)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 6 commits:

↗️ addressable (indirect, 2.8.5 → 2.8.6) · Repo · Changelog

Release Notes

2.8.6 (from changelog)

  • Memoize regexps for common character classes (#524)

Does any of this look wrong? Please let us know.

↗️ marcel (indirect, 1.0.2 → 1.0.4) · Repo

Release Notes

1.0.4

What's Changed

  • Regression fix: binary declared type should fall back to filename extension type by @jeremy in #99

Full Changelog: v1.0.3...v1.0.4

1.0.3

What's Changed

New Contributors

Full Changelog: v1.0.2...v1.0.3

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 27 commits:

↗️ ruby-vips (indirect, 2.2.0 → 2.2.1) · Repo · Changelog

Release Notes

2.2.1 (from changelog)

  • add Vips.block_untrusted method to block all untrusted operations. Only for libvips >= 8.13. Docs. #382 aglushkov
  • add Vips.block method to block specific operation. Only for libvips >= 8.13. Docs. #382 aglushkov
  • new_from_source keeps a ref to the source object [taylorthurlow]
  • some fixes to object references system

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 12 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added depfu Automatically created by Depfu Technical Debt labels Mar 11, 2024
Copy link

codeclimate bot commented Mar 12, 2024

Code Climate has analyzed commit 17e0c64 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 86.6% (0.0% change).

View more on Code Climate.

@yoldas yoldas self-assigned this Mar 12, 2024
@yoldas yoldas merged commit d1c7aee into develop Mar 12, 2024
21 checks passed
@yoldas yoldas deleted the depfu/update/carrierwave-3.0.6 branch March 12, 2024 12:56
@yoldas
Copy link
Member

yoldas commented Mar 18, 2024

Testing (copied from Slack posts)

I have created a Stock Plate using UAT actions > Generate Plate: UAT SQPU-80588-W
I copied a file from production to my machine and renamed it to SQPU-80588-W.CSV and replaced all values in the barcode in RACKID column with the SQPU-80588-W .

RACKID,TUBE,VOLAVG
SQPU-80588-W,A01,85.6835
SQPU-80588-W,B01,84.1618


I have copied it to volume_check folder in UAT

scp SQPU-80588-W.CSV sss0-uat.psd.sanger.ac.uk:~/
ssh sss0-uat.psd.sanger.ac.uk
sudo mv SQPU-80588-W.CSV /opt/share/ss_datadrop/Data/volume_check/

The config/schedule.rb file sepecifies every hour for the task lib/volume_check.rb . (This is the whenever gem setup).

plate_volumes and qc_results tables of sequencescape_staging and qc_result table of mlwhd_mlwarehouse_devdata were updated with the records. I changed the file, and I observed the changes in the records again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depfu Automatically created by Depfu Technical Debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants