Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RT #790461 - Novaseq X 25B and 1.5B flowcell - Sequencescape options #3919

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

KatyTaylor
Copy link
Contributor

@KatyTaylor KatyTaylor commented Oct 18, 2023

Closes RT # 790461

Changes proposed in this pull request

  • Add default records, to generate data for new Novaseq X flowcell types

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

@KatyTaylor
Copy link
Contributor Author

The changes in this PR generate the bottom two lines of data in this screenshot:
Screenshot 2023-10-18 at 13 32 11

@KatyTaylor
Copy link
Contributor Author

Locally, this increases the options in the "Flowcell type" dropdown from just "10B", to "1.5B", "10B", and "25B". See screenshot below:
Screenshot 2023-10-18 at 14 35 56

@codeclimate
Copy link

codeclimate bot commented Oct 18, 2023

Code Climate has analyzed commit 18795f8 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 88.4% (0.0% change).

View more on Code Climate.

@KatyTaylor KatyTaylor marked this pull request as ready for review October 18, 2023 13:49
@KatyTaylor KatyTaylor self-assigned this Oct 18, 2023
@KatyTaylor KatyTaylor merged commit e29d0c3 into develop Oct 19, 2023
21 checks passed
@KatyTaylor KatyTaylor deleted the rt-790461-new-flowcell-types branch October 19, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants