Skip to content

Commit

Permalink
Add issue reference to address PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
KatyTaylor committed Mar 11, 2024
1 parent f4afdf7 commit 3f029c1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion app/models/sample_manifest.rb
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ def default_filename
# Use a default value of 1 for rows_per_well if not set
def rows_per_well
1
# TODO: replace above line with below line when we want to turn the 'rows_per_well' feature on
# TODO: replace above line with below line to turn the rows_per_well feature on, when DPL-823 is complete
# @rows_per_well || 1
end

Expand Down
4 changes: 2 additions & 2 deletions spec/models/sample_manifest/generator_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@
context 'with rows_per_well set' do
let(:template) { 'pools_plate' }

# TODO: un-skip when rows_per_well feature is enabled
# TODO: un-skip when rows_per_well feature is enabled (when DPL-823 is complete)
skip 'generates a details array with more than one entry per well' do

Check warning on line 132 in spec/models/sample_manifest/generator_spec.rb

View workflow job for this annotation

GitHub Actions / rspec_tests (3, 2)

SampleManifest::Generator with rows_per_well set generates a details array with more than one entry per well Skipped: No reason given

Check warning on line 132 in spec/models/sample_manifest/generator_spec.rb

View workflow job for this annotation

GitHub Actions / rspec_tests (3, 1)

SampleManifest::Generator with rows_per_well set generates a details array with more than one entry per well Skipped: No reason given
generator = described_class.new(attributes, user, configuration)
generator.execute
Expand All @@ -137,7 +137,7 @@
end

context 'with rows_per_well not set' do
# TODO: un-skip when rows_per_well feature is enabled
# TODO: un-skip when rows_per_well feature is enabled (when DPL-823 is complete)
skip 'generates a details array with one entry per well' do

Check warning on line 141 in spec/models/sample_manifest/generator_spec.rb

View workflow job for this annotation

GitHub Actions / rspec_tests (3, 2)

SampleManifest::Generator with rows_per_well not set generates a details array with one entry per well Skipped: No reason given

Check warning on line 141 in spec/models/sample_manifest/generator_spec.rb

View workflow job for this annotation

GitHub Actions / rspec_tests (3, 1)

SampleManifest::Generator with rows_per_well not set generates a details array with one entry per well Skipped: No reason given
generator = described_class.new(attributes, user, configuration)
generator.execute
Expand Down

0 comments on commit 3f029c1

Please sign in to comment.