Update rails to version 6.1.7.7 #5389
Annotations
11 errors and 10 warnings
|
Run rspec tests:
spec/models/sample_manifest/uploader_spec.rb#L27
SampleManifest::Uploader will not be valid without some configuration
Failure/Error: upload.errors.each { |key, value| errors.add key, value }
ActiveSupport::DeprecationException:
DEPRECATION WARNING: Enumerating ActiveModel::Errors as a hash has been deprecated.
In Rails 6.1, `errors` is an array of Error objects,
therefore it should be accessed by a block with a single block
parameter like this:
person.errors.each do |error|
attribute = error.attribute
message = error.message
end
You are passing a block expecting two parameters,
so the old hash behavior is simulated. As this is deprecated,
this will result in an ArgumentError in Rails 7.0.
(called from extract_errors at /home/runner/work/sequencescape/sequencescape/app/models/sample_manifest/uploader.rb:69)
|
Run rspec tests:
spec/models/sample_manifest/uploader_spec.rb#L23
SampleManifest::Uploader will not be valid without a filename
Failure/Error: object.errors.each { |key, value| errors.add key, value }
ActiveSupport::DeprecationException:
DEPRECATION WARNING: Enumerating ActiveModel::Errors as a hash has been deprecated.
In Rails 6.1, `errors` is an array of Error objects,
therefore it should be accessed by a block with a single block
parameter like this:
person.errors.each do |error|
attribute = error.attribute
message = error.message
end
You are passing a block expecting two parameters,
so the old hash behavior is simulated. As this is deprecated,
this will result in an ArgumentError in Rails 7.0.
(called from check_object at /home/runner/work/sequencescape/sequencescape/app/sample_manifest_excel/sample_manifest_excel/upload/base.rb:164)
|
Run rspec tests:
spec/models/sample_manifest/uploader_spec.rb#L205
SampleManifest::Uploader when checking uploads will not upload an invalid multiplexed library tube with tag sequences sample manifest
Failure/Error: object.errors.each { |key, value| errors.add key, value }
ActiveSupport::DeprecationException:
DEPRECATION WARNING: Enumerating ActiveModel::Errors as a hash has been deprecated.
In Rails 6.1, `errors` is an array of Error objects,
therefore it should be accessed by a block with a single block
parameter like this:
person.errors.each do |error|
attribute = error.attribute
message = error.message
end
You are passing a block expecting two parameters,
so the old hash behavior is simulated. As this is deprecated,
this will result in an ArgumentError in Rails 7.0.
(called from check_object at /home/runner/work/sequencescape/sequencescape/app/sample_manifest_excel/sample_manifest_excel/upload/base.rb:164)
|
Run rspec tests:
spec/models/sample_manifest/uploader_spec.rb#L64
SampleManifest::Uploader when checking uploads will upload a valid 1d tube sample manifest
Failure/Error:
ActiveRecord::Base.transaction do
return false unless valid? # rubocop:todo Rails/TransactionExitStatement
return true if process_upload_and_callbacks # rubocop:todo Rails/TransactionExitStatement
# One of our post processing checks failed, something went wrong, so we
# roll everything back
raise ActiveRecord::Rollback
end
ActiveSupport::DeprecationException:
DEPRECATION WARNING: Using `return`, `break` or `throw` to exit a transaction block is
deprecated without replacement. If the `throw` came from
`Timeout.timeout(duration)`, pass an exception class as a second
argument so it doesn't use `throw` to abort its block. This results
in the transaction being committed, but in the next release of Rails
it will rollback.
(called from run! at /home/runner/work/sequencescape/sequencescape/app/models/sample_manifest/uploader.rb:31)
|
Run rspec tests:
spec/models/sample_manifest/uploader_spec.rb#L297
SampleManifest::Uploader when checking uploads will upload a valid partial plate sample manifest
Failure/Error:
FactoryBot.create(
:pending_plate_sample_manifest,
num_plates: num_plates,
num_samples_per_plate: num_samples_per_plate,
study: study
)
ActiveRecord::RecordInvalid:
Validation failed: Login has already been taken
|
Run rspec tests:
spec/models/sample_manifest/uploader_spec.rb#L269
SampleManifest::Uploader when checking uploads will upload a valid partial multiplexed library tube with tag sequences sample manifest
Failure/Error: FactoryBot.create(:empty_library_tube)
ActiveRecord::RecordInvalid:
Validation failed: Name has already been taken
|
Run rspec tests:
spec/models/sample_manifest/uploader_spec.rb#L115
SampleManifest::Uploader when checking uploads will upload a valid multiplexed library tube with tag sequences sample manifest
Failure/Error: FactoryBot.create(:empty_library_tube)
ActiveRecord::RecordInvalid:
Validation failed: Name has already been taken
|
Run rspec tests:
spec/models/sample_manifest/uploader_spec.rb#L132
SampleManifest::Uploader when checking uploads will upload a valid multiplexed library tube with tag groups and indexes sample manifest
Failure/Error: FactoryBot.create(:empty_library_tube)
ActiveRecord::RecordInvalid:
Validation failed: Name has already been taken
|
Run rspec tests:
spec/models/sample_manifest/uploader_spec.rb#L283
SampleManifest::Uploader when checking uploads will upload a valid partial multiplexed library tube with tag groups and indexes
Failure/Error: FactoryBot.create(:empty_library_tube)
ActiveRecord::RecordInvalid:
Validation failed: Name has already been taken
|
Run rspec tests:
spec/models/sample_manifest/uploader_spec.rb#L149
SampleManifest::Uploader when checking uploads will upload a valid plate sample manifest
Failure/Error:
FactoryBot.create(
:pending_plate_sample_manifest,
num_plates: num_plates,
num_samples_per_plate: num_samples_per_plate,
study: study
)
ActiveRecord::RecordInvalid:
Validation failed: Login has already been taken
|
Run rspec tests:
spec/lib/record_loader/request_type_validators_loader_spec.rb#L22
RecordLoader::RequestTypeValidatorsLoader with two_entry_example selected is idempotent
Skipped: Temporarily skipped with xit
|
Run rspec tests:
spec/lib/record_loader/request_type_validators_loader_spec.rb#L16
RecordLoader::RequestTypeValidatorsLoader with two_entry_example selected creates two records
Skipped: Temporarily skipped with xit
|
Run rspec tests:
spec/lib/record_loader/request_type_validators_loader_spec.rb#L27
RecordLoader::RequestTypeValidatorsLoader with two_entry_example selected sets attributes on the created records
Skipped: Temporarily skipped with xit
|
Run rspec tests:
spec/models/sample_manifest/generator_spec.rb#L132
SampleManifest::Generator with rows_per_well set generates a details array with more than one entry per well
Skipped: No reason given
|
Run rspec tests:
spec/models/sample_manifest/generator_spec.rb#L141
SampleManifest::Generator with rows_per_well not set generates a details array with one entry per well
Skipped: No reason given
|
Run rspec tests:
spec/models/plate_purpose/additional_input_spec.rb#L32
PlatePurpose::AdditionalInput#state_of with ancestors with no library requests is pending
Skipped: Temporarily skipped with xit
|
Run rspec tests:
spec/models/plate_purpose/additional_input_spec.rb#L43
PlatePurpose::AdditionalInput#state_of with ancestors with library requests is pending
Skipped: Temporarily skipped with xit
|
Run rspec tests:
spec/models/plate_purpose/additional_input_spec.rb#L22
PlatePurpose::AdditionalInput#state_of with no requests is pending
Skipped: Temporarily skipped with xit
|
Run rspec tests:
spec/models/plate_purpose/additional_input_spec.rb#L64
PlatePurpose::AdditionalInput#state_of with no ancestors with library requests is passed
Skipped: Temporarily skipped with xit
|
Run rspec tests:
spec/models/plate_purpose/additional_input_spec.rb#L53
PlatePurpose::AdditionalInput#state_of with no ancestors with no library requests is pending
Skipped: Temporarily skipped with xit
|
Loading