Skip to content

Reverting rubocop styles to pass the tests initially #5360

Reverting rubocop styles to pass the tests initially

Reverting rubocop styles to pass the tests initially #5360

Status Failure
Total duration 8m 30s
Artifacts 5

ruby_test.yml

on: push
Matrix: cucumber_tests
Matrix: rspec_tests
end_coverage
0s
end_coverage
Fit to window
Zoom out
Zoom in

Annotations

34 errors and 14 warnings
rake_tests
Process completed with exit code 1.
rspec_tests (3, 1): spec/controllers/npg_actions/assets_controller_spec.rb#L39
NpgActions::AssetsController#pass with valid parameters behaves like a passed state change renders and creates events Failure/Error: format.html { render template: 'assets/show.xml.builder' } ActiveSupport::DeprecationException: DEPRECATION WARNING: Rendering actions with '.' in the name is deprecated: assets/show.xml.builder (called from block (3 levels) in action_for_qc_state at /home/runner/work/sequencescape/sequencescape/app/controllers/npg_actions/assets_controller.rb:41) Shared Example Group: "a passed state change" called from ./spec/controllers/npg_actions/assets_controller_spec.rb:125
rspec_tests (3, 1): spec/controllers/npg_actions/assets_controller_spec.rb#L269
NpgActions::AssetsController#pass when changing qc state on an asset after NPG did the same action before renders and but does not recreate the events Failure/Error: format.html { render template: 'assets/show.xml.builder' } ActiveSupport::DeprecationException: DEPRECATION WARNING: Rendering actions with '.' in the name is deprecated: assets/show.xml.builder (called from block (3 levels) in action_for_qc_state at /home/runner/work/sequencescape/sequencescape/app/controllers/npg_actions/assets_controller.rb:41)
rspec_tests (3, 1): spec/controllers/npg_actions/assets_controller_spec.rb#L39
NpgActions::AssetsController#pass with both an active and an additional cancelled request behaves like a passed state change renders and creates events Failure/Error: format.html { render template: 'assets/show.xml.builder' } ActiveSupport::DeprecationException: DEPRECATION WARNING: Rendering actions with '.' in the name is deprecated: assets/show.xml.builder (called from block (3 levels) in action_for_qc_state at /home/runner/work/sequencescape/sequencescape/app/controllers/npg_actions/assets_controller.rb:41) Shared Example Group: "a passed state change" called from ./spec/controllers/npg_actions/assets_controller_spec.rb:194
rspec_tests (3, 1): spec/controllers/npg_actions/assets_controller_spec.rb#L302
NpgActions::AssetsController#pass when posting invalid XML to change qc state on an asset. NPG did the same action before renders the exception page Failure/Error: expect(response.body).to match(regexp) expected "<error><message>param is missing or the value is empty: qc_information\nDid you mean? action\n unknown_attribute\n controller\n asset_id</message></error>" to match /<error><message>param is missing or the value is empty: qc_information<\/message><\/error>/m Diff: @@ -1,5 +1,9 @@ -/<error><message>param is missing or the value is empty: qc_information<\/message><\/error>/m +<error><message>param is missing or the value is empty: qc_information +Did you mean? action + unknown_attribute + controller + asset_id</message></error>
rspec_tests (3, 1): spec/controllers/npg_actions/assets_controller_spec.rb#L64
NpgActions::AssetsController#fail with both a valid and an additional cancelled request behaves like a failed state change renders and creates events Failure/Error: format.html { render template: 'assets/show.xml.builder' } ActiveSupport::DeprecationException: DEPRECATION WARNING: Rendering actions with '.' in the name is deprecated: assets/show.xml.builder (called from block (3 levels) in action_for_qc_state at /home/runner/work/sequencescape/sequencescape/app/controllers/npg_actions/assets_controller.rb:41) Shared Example Group: "a failed state change" called from ./spec/controllers/npg_actions/assets_controller_spec.rb:368
rspec_tests (3, 1): spec/controllers/npg_actions/assets_controller_spec.rb#L64
NpgActions::AssetsController#fail with valid parameters behaves like a failed state change renders and creates events Failure/Error: format.html { render template: 'assets/show.xml.builder' } ActiveSupport::DeprecationException: DEPRECATION WARNING: Rendering actions with '.' in the name is deprecated: assets/show.xml.builder (called from block (3 levels) in action_for_qc_state at /home/runner/work/sequencescape/sequencescape/app/controllers/npg_actions/assets_controller.rb:41) Shared Example Group: "a failed state change" called from ./spec/controllers/npg_actions/assets_controller_spec.rb:352
rspec_tests (3, 1): spec/features/sample_manifests/uploader_for_manifests_with_tag_sequences_spec.rb#L204
Sample manifest with tag sequences multiplexed tube sample manifest with tag sequences valid cgap foreign barcodes upload Failure/Error: ActiveRecord::Base.transaction do return false unless valid? # rubocop:todo Rails/TransactionExitStatement return true if process_upload_and_callbacks # rubocop:todo Rails/TransactionExitStatement # One of our post processing checks failed, something went wrong, so we # roll everything back raise ActiveRecord::Rollback end ActiveSupport::DeprecationException: DEPRECATION WARNING: Using `return`, `break` or `throw` to exit a transaction block is deprecated without replacement. If the `throw` came from `Timeout.timeout(duration)`, pass an exception class as a second argument so it doesn't use `throw` to abort its block. This results in the transaction being committed, but in the next release of Rails it will rollback. (called from run! at /home/runner/work/sequencescape/sequencescape/app/models/sample_manifest/uploader.rb:31)
rspec_tests (3, 1): spec/features/sample_manifests/uploader_for_manifests_with_tag_sequences_spec.rb#L157
Sample manifest with tag sequences multiplexed tube sample manifest with tag sequences valid upload and reupload with override Failure/Error: let!(:user) { create :admin } ActiveRecord::RecordInvalid: Validation failed: Login has already been taken
rspec_tests (3, 1): spec/features/sample_manifests/uploader_for_manifests_with_tag_sequences_spec.rb#L496
Sample manifest with tag sequences plate sample manifest invalid unrecognised cgap foreign barcodes validation errors Failure/Error: let!(:user) { create :admin } ActiveRecord::RecordInvalid: Validation failed: Login has already been taken
rspec_tests (3, 1): spec/features/sample_manifests/uploader_for_manifests_with_tag_sequences_spec.rb#L479
Sample manifest with tag sequences plate sample manifest invalid no file no file Failure/Error: let!(:user) { create :admin } ActiveRecord::RecordInvalid: Validation failed: Login has already been taken
rspec_tests (3, 2)
The job was canceled because "_3_1" failed.
rspec_tests (3, 2): spec/models/sample_manifest/uploader_spec.rb#L164
SampleManifest::Uploader when checking uploads will generate sample accessions Failure/Error: ActiveRecord::Base.transaction do return false unless valid? # rubocop:todo Rails/TransactionExitStatement return true if process_upload_and_callbacks # rubocop:todo Rails/TransactionExitStatement # One of our post processing checks failed, something went wrong, so we # roll everything back raise ActiveRecord::Rollback end ActiveSupport::DeprecationException: DEPRECATION WARNING: Using `return`, `break` or `throw` to exit a transaction block is deprecated without replacement. If the `throw` came from `Timeout.timeout(duration)`, pass an exception class as a second argument so it doesn't use `throw` to abort its block. This results in the transaction being committed, but in the next release of Rails it will rollback. (called from run! at /home/runner/work/sequencescape/sequencescape/app/models/sample_manifest/uploader.rb:31)
rspec_tests (3, 2): spec/models/sample_manifest/uploader_spec.rb#L64
SampleManifest::Uploader when checking uploads will upload a valid 1d tube sample manifest Failure/Error: Study.find_by(name: new_study) || FactoryBot.create(:study, name: new_study) ActiveRecord::RecordInvalid: Validation failed: Login has already been taken
rspec_tests (3, 2): spec/models/sample_manifest/uploader_spec.rb#L132
SampleManifest::Uploader when checking uploads will upload a valid multiplexed library tube with tag groups and indexes sample manifest Failure/Error: Study.find_by(name: new_study) || FactoryBot.create(:study, name: new_study) ActiveRecord::RecordInvalid: Validation failed: Login has already been taken
rspec_tests (3, 2): spec/models/sample_manifest/uploader_spec.rb#L269
SampleManifest::Uploader when checking uploads will upload a valid partial multiplexed library tube with tag sequences sample manifest Failure/Error: Study.find_by(name: new_study) || FactoryBot.create(:study, name: new_study) ActiveRecord::RecordInvalid: Validation failed: Login has already been taken
rspec_tests (3, 2): spec/models/sample_manifest/uploader_spec.rb#L181
SampleManifest::Uploader when checking uploads will not upload an invalid 1d tube sample manifest Failure/Error: Study.find_by(name: new_study) || FactoryBot.create(:study, name: new_study) ActiveRecord::RecordInvalid: Validation failed: Login has already been taken
rspec_tests (3, 2): spec/models/sample_manifest/uploader_spec.rb#L283
SampleManifest::Uploader when checking uploads will upload a valid partial multiplexed library tube with tag groups and indexes Failure/Error: Study.find_by(name: new_study) || FactoryBot.create(:study, name: new_study) ActiveRecord::RecordInvalid: Validation failed: Login has already been taken
rspec_tests (3, 2): spec/models/sample_manifest/uploader_spec.rb#L193
SampleManifest::Uploader when checking uploads will not upload an invalid library tube with tag sequences sample manifest Failure/Error: Study.find_by(name: new_study) || FactoryBot.create(:study, name: new_study) ActiveRecord::RecordInvalid: Validation failed: Login has already been taken
rspec_tests (3, 0)
The job was canceled because "_3_1" failed.
rspec_tests (3, 2): spec/models/sample_manifest/uploader_spec.rb#L81
SampleManifest::Uploader when checking uploads will upload a valid library tube with tag sequences sample manifest Failure/Error: Study.find_by(name: new_study) || FactoryBot.create(:study, name: new_study) ActiveRecord::RecordInvalid: Validation failed: Login has already been taken
rspec_tests (3, 2): spec/models/sample_manifest/uploader_spec.rb#L241
SampleManifest::Uploader when checking uploads will upload a valid partial 1d tube sample manifest Failure/Error: Study.find_by(name: new_study) || FactoryBot.create(:study, name: new_study) ActiveRecord::RecordInvalid: Validation failed: Login has already been taken
rspec_tests (3, 2): spec/models/sample_manifest/uploader_spec.rb#L205
SampleManifest::Uploader when checking uploads will not upload an invalid multiplexed library tube with tag sequences sample manifest Failure/Error: Study.find_by(name: new_study) || FactoryBot.create(:study, name: new_study) ActiveRecord::RecordInvalid: Validation failed: Login has already been taken
cucumber_tests (2, 1): features/api/uk10k/orders.feature#L364
Trying to update invalid request options failed: Expected: 422
cucumber_tests (2, 1): features/api/uk10k/orders.feature#L365
Trying to update invalid request options failed: Expected: 422
cucumber_tests (2, 1): features/api/uk10k/orders.feature#L366
Trying to update invalid request options failed: Expected: 422
cucumber_tests (2, 1): features/api/uk10k/orders.feature#L367
Trying to update invalid request options failed: Expected: 422
cucumber_tests (2, 1): features/api/uk10k/orders.feature#L371
Trying to update invalid request options failed: Expected: 422
cucumber_tests (2, 1)
Process completed with exit code 1.
cucumber_tests (2, 0)
The job was canceled because "_2_1" failed.
cucumber_tests (2, 0): features/api/pulldown/submissions.feature#L43
A submission should error if you set an incorrect request option on construction failed: Expected: 422
cucumber_tests (2, 0): features/api/pulldown/submissions.feature#L79
A submission should not error if you create it without required options, but does if you build it failed: Expected: 422
cucumber_tests (2, 0): features/11803383_bug_NPG_batch_state_released.feature#L14
POST XML to change qc_state on a asset failed: Expected: 200
cucumber_tests (2, 0)
Process completed with exit code 1.
rake_tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
rake_tests
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
rspec_tests (3, 1)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/setup-node@v2, actions/upload-artifact@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
rspec_tests (3, 1)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v2, actions/upload-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
rspec_tests (3, 1): spec/lib/record_loader/request_type_validators_loader_spec.rb#L16
RecordLoader::RequestTypeValidatorsLoader with two_entry_example selected creates two records Skipped: Temporarily skipped with xit
rspec_tests (3, 1): spec/lib/record_loader/request_type_validators_loader_spec.rb#L22
RecordLoader::RequestTypeValidatorsLoader with two_entry_example selected is idempotent Skipped: Temporarily skipped with xit
rspec_tests (3, 1): spec/lib/record_loader/request_type_validators_loader_spec.rb#L27
RecordLoader::RequestTypeValidatorsLoader with two_entry_example selected sets attributes on the created records Skipped: Temporarily skipped with xit
rspec_tests (3, 2): spec/models/plate_purpose/additional_input_spec.rb#L53
PlatePurpose::AdditionalInput#state_of with no ancestors with no library requests is pending Skipped: Temporarily skipped with xit
rspec_tests (3, 2): spec/models/plate_purpose/additional_input_spec.rb#L64
PlatePurpose::AdditionalInput#state_of with no ancestors with library requests is passed Skipped: Temporarily skipped with xit
rspec_tests (3, 2): spec/models/plate_purpose/additional_input_spec.rb#L22
PlatePurpose::AdditionalInput#state_of with no requests is pending Skipped: Temporarily skipped with xit
rspec_tests (3, 2): spec/models/plate_purpose/additional_input_spec.rb#L32
PlatePurpose::AdditionalInput#state_of with ancestors with no library requests is pending Skipped: Temporarily skipped with xit
rspec_tests (3, 2): spec/models/plate_purpose/additional_input_spec.rb#L43
PlatePurpose::AdditionalInput#state_of with ancestors with library requests is pending Skipped: Temporarily skipped with xit
cucumber_tests (2, 1)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/setup-node@v3, actions/upload-artifact@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
cucumber_tests (2, 1)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/upload-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Artifacts

Produced during runtime
Name Size
capybara-cucumber_tests-0 Expired
219 Bytes
capybara-cucumber_tests-1 Expired
44 Bytes
capybara-rspec_tests-1 Expired
57.6 KB
capybara-rspec_tests-2 Expired
51.2 KB
codeclimate-rspec_tests-0 Expired
1.45 MB