Add new method to null column list to fix test #5338
KatyTaylorAnnotations
8 errors and 4 warnings
|
rubocop:
app/models/sample_manifest/core_behaviour.rb#L51
Lint/UnusedMethodArgument: Unused method argument - `row`. If it's necessary, use `_` or `_row` as an argument name to indicate that it won't be used. If it's unnecessary, remove it. (https://rubystyle.guide#underscore-unused-vars)
|
|
rubocop:
app/sample_manifest_excel/sample_manifest_excel/upload/row.rb#L29
Metrics/CyclomaticComplexity: Cyclomatic complexity for initialize is too high. [8/7]
|
|
rubocop:
app/sample_manifest_excel/sample_manifest_excel/upload/rows.rb#L48
Metrics/AbcSize: Assignment Branch Condition size for find_pools_if_present is too high. [<6, 19, 14> 24.35/17] (http://c2.com/cgi/wiki?AbcMetric, https://en.wikipedia.org/wiki/ABC_Software_Metric)
|
|
rubocop:
app/sample_manifest_excel/sample_manifest_excel/upload/rows.rb#L48
Metrics/CyclomaticComplexity: Cyclomatic complexity for find_pools_if_present is too high. [15/7]
|
|
rubocop:
app/sample_manifest_excel/sample_manifest_excel/upload/rows.rb#L48
Metrics/PerceivedComplexity: Perceived complexity for find_pools_if_present is too high. [15/8]
|
|
rubocop:
app/sequencescape_excel/sequencescape_excel/column_list.rb#L99
Naming/PredicateName: Rename `has_tags?` to `tags?`. (https://rubystyle.guide#bool-methods-qmark)
|
|
rubocop:
app/sequencescape_excel/sequencescape_excel/null_objects/null_column_list.rb#L30
Naming/PredicateName: Rename `has_tags?` to `tags?`. (https://rubystyle.guide#bool-methods-qmark)
|
|
rubocop
Process completed with exit code 1.
|
|
EsLint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
EsLint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
rubocop
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/setup-node@v3, actions/cache@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
rubocop
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|