Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPL-670-8 Add Sequencescape API Key config for V2 API #279

Merged
merged 3 commits into from
Dec 8, 2023

Conversation

BenTopping
Copy link

Closes #273

Changes proposed in this pull request

  • adds api key header to sequencescape v2 requests

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

Copy link

@KatyTaylor KatyTaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't seen the code for this stuff before, but I will believe you know what you're doing (and guessing you'll test it first in UAT!)

@BenTopping BenTopping requested a review from emrojo December 5, 2023 10:18
Copy link

@emrojo emrojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just thinking, would it be possible to have a test checking that the api key is present when using the v2 client?

@BenTopping BenTopping requested a review from emrojo December 5, 2023 14:17
@BenTopping BenTopping merged commit 10ec747 into develop Dec 8, 2023
6 checks passed
@BenTopping BenTopping deleted the DPL-670-8-sequencescape-v2-api-key branch December 8, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DPL-670-8 Pass a Samples Extraction specific API key to Sequencescape calls
3 participants