Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace webpack with vite to enable Vue3 upgrade #270

Merged
merged 5 commits into from
Nov 27, 2023

Conversation

Sangeetha-Bheeman
Copy link
Contributor

…for jest

Closes #

Changes proposed in this pull request

  • Replace webpack with Vite
  • Added dependencies for jest

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

@stevieing stevieing removed their request for review November 6, 2023 09:18
Copy link
Collaborator

@stevieing stevieing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems ok. Might be worth fixing the eslint warning as we will probably add eslint as required. I don't think it is at the moment.

server.js Outdated Show resolved Hide resolved
@Sangeetha-Bheeman Sangeetha-Bheeman merged commit ae97ff5 into develop Nov 27, 2023
6 checks passed
@Sangeetha-Bheeman Sangeetha-Bheeman deleted the dpl-890-2-replace-webpack-with-vite branch November 27, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DPL-890-2 Replace webpack with Vite to ensure maintainability and security and enable us to upgrade to Vue 3
2 participants