Y25-012 - Changes to scRNA Core binning rules #2154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2154 +/- ##
========================================
Coverage 80.76% 80.76%
========================================
Files 477 477
Lines 18148 18148
Branches 269 269
========================================
Hits 14658 14658
Misses 3488 3488
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andrewsparkes
approved these changes
Jan 10, 2025
Yes, there's a linked story and a conversation in Slack. Don't think they should need to do it often. For the binning ranges, Abby requested it 6 months ago but I mis-read it. |
yoldas
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Looks good. I have checked
- diluent volume is configured to be 25 now instead of zero.
- per cycles are correct according to the Recommended Cycle Numbers table.
- mid-point of Total Cycles is taken for each cDNA input.
- for the smallest input only the max specified. OK.
- for the biggest input only the min specified. OK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Also see Integration Suite PR - https://gitlab.internal.sanger.ac.uk/psd/integration-suite/-/merge_requests/208/diffs
Changes proposed in this pull request
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version