Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-190: Use SS API V2 for Qcable resources #2135

Merged
merged 5 commits into from
Jan 13, 2025

Conversation

sdjmchattie
Copy link
Contributor

Closes #1818

Changes proposed in this pull request

  • Pull Qcables from Sequencescape API v2.
  • Change which attributes we extract from the Qcable to align with V2 API usage.
  • Update tests to match.

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code

@sdjmchattie sdjmchattie self-assigned this Dec 18, 2024
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.79%. Comparing base (22ff482) to head (c52999d).
Report is 36 commits behind head on develop-Y24-190.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           develop-Y24-190    #2135      +/-   ##
===================================================
+ Coverage            80.65%   80.79%   +0.13%     
===================================================
  Files                  477      481       +4     
  Lines                18148    18248     +100     
  Branches               268      269       +1     
===================================================
+ Hits                 14638    14743     +105     
+ Misses                3508     3503       -5     
  Partials                 2        2              
Flag Coverage Δ
javascript 74.23% <ø> (+0.17%) ⬆️
pull_request 80.78% <100.00%> (?)
push 80.67% <100.00%> (+0.01%) ⬆️
ruby 91.19% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@BenTopping BenTopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@sdjmchattie sdjmchattie merged commit 87b191a into develop-Y24-190 Jan 13, 2025
16 checks passed
@sdjmchattie sdjmchattie deleted the Y24-190-use-v2-for-qcables branch January 13, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants