-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding a new plate purpose for multiplexed sequencing submissions, to avoid FC #2120
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2120 +/- ##
========================================
Coverage 80.76% 80.76%
========================================
Files 477 477
Lines 18148 18148
Branches 269 269
========================================
Hits 14658 14658
Misses 3488 3488
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a integration suite update for this?
good point, I will try to add some |
Hey, how did you decide which pipeline files to add this into? Thanks |
I basically checked the ones used by LB-Lib-PCR-XP, as from the story they are doing a FC to create a LB-Lib-PCR-XP and then perform the multiplexing - it might be more generic way of doing it through |
OK yep. Could be worth telling the customer which pipelines you've added it too, and checking that it's relevant to all of them. Wondering particularly about ISC because it comes in half way and it's not just doing multiplexing - there's bait capture hybridization (or something) happening. |
Thank you, I will do, do we have a slack channel for this ? I know Liz and Siobhan are the key persons to ask.. |
…07-new-plate-purpose
…07-new-plate-purpose
@@ -28,7 +28,7 @@ def all_wells_in_pool_passed?(pool_info) | |||
end | |||
|
|||
def pick?(location) | |||
well_locations.fetch(location).passed? | |||
!(well_locations.fetch(location).failed? || well_locations.fetch(location).empty?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed because when the multiplexing pipeline starts with a stock plate (rather than a cherrypick plate, or one coming from a library prep pipeline), the wells are of state 'unknown'
No description provided.