Y24 335 updating flowcel types and library types #2062
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2062 +/- ##
===========================================
+ Coverage 77.98% 78.09% +0.10%
===========================================
Files 471 477 +6
Lines 17975 18065 +90
Branches 262 262
===========================================
+ Hits 14018 14108 +90
Misses 3955 3955
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
…lowcel-types-and-library-types
Y24 335 fixing label priting
There was a problem hiding this comment.
Had to take this out of Bespoke PCR pipeline config to make limber_hic WIP-able.
| 'extra_right_text' => 'some x right text', | ||
| 'extra_left_text' => 'some x left text' | ||
| } | ||
| sprint: [{ 'extra_right_text' => 'some x right text', 'extra_left_text' => 'some x left text' }] | ||
| }, |
There was a problem hiding this comment.
Why is this changed to an array?
As far as I know, labels_sprint object provides all attributes in a single object. The labels object on the other hand has separate objects for main label and lid label for a tube in an array for example.
There was a problem hiding this comment.
When given on a single object (as the image above), if you have multiple tube labels to be printed, the previous tubes will be overwritten by the last tube; therefore printing only the last tube label.
There was a problem hiding this comment.
Thanks. So it fixes the issue for Squix printing. That will be still a problem if Toshiba printing is used then. Because the array there is not for multiple labels; it is for sections of a single label. Looking again all keys are in the same object so what I said is not correct. Sorry.
dasunpubudumal
deleted the
y24-335-updating-flowcel-types-and-library-types
branch
Closes #
Changes proposed in this pull request
limber_hicrequest type.The corresponding sequencescape changes are sanger/sequencescape#4497.
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version