Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPL-823 [Limber part] Import PBMC pool plates into Sequencescape #1576

Merged

Conversation

KatyTaylor
Copy link
Contributor

@KatyTaylor KatyTaylor commented Feb 7, 2024

Main changes for this story are in Sequencescape - sanger/sequencescape#4017

Changes proposed in this pull request

  • LRC PBMC Pools Input must be a 'stock plate' so that it can be used in sample manifests in Sequencescape

When deploying to UAT, ssh onto Sequencescape server and run in Rails console:

p = Purpose.find_by(name: 'LRC PBMC Pools Input')
p.stock_plate = true
p.save!

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

@KatyTaylor KatyTaylor marked this pull request as ready for review February 27, 2024 13:57
@KatyTaylor KatyTaylor self-assigned this Feb 27, 2024
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@d08cc42). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1576   +/-   ##
==========================================
  Coverage           ?   90.65%           
==========================================
  Files              ?      354           
  Lines              ?     7276           
  Branches           ?        0           
==========================================
  Hits               ?     6596           
  Misses             ?      680           
  Partials           ?        0           
Flag Coverage Δ
javascript 93.64% <ø> (?)
pull_request 90.65% <ø> (?)
ruby 90.21% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codeclimate bot commented Feb 27, 2024

Code Climate has analyzed commit ea55ebc and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 90.1% (0.0% change).

View more on Code Climate.

@@ -26,7 +26,8 @@ LRC PBMC Pools:
# This plate has come from faculty and is entering the SeqOps pipeline for the first time here.
LRC PBMC Pools Input:
:asset_type: plate
:stock_plate: false
# stock_plate has to be true so that it appears in the 'Purpose' list when generating a sample manifest in Sequencescape
:stock_plate: true
:input_plate: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was comparing this to Bioscan Lysate plate and it is similar there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking

@KatyTaylor KatyTaylor merged commit 62aa86c into develop Mar 1, 2024
11 checks passed
@KatyTaylor KatyTaylor deleted the DPL-823-Import-PBMC-pool-plates-into-Sequencescape branch March 1, 2024 15:41
@KatyTaylor KatyTaylor changed the title DPL-823 Import PBMC pool plates into Sequencescape DPL-823 [Limber part] Import PBMC pool plates into Sequencescape Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants