-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DPL-823 [Limber part] Import PBMC pool plates into Sequencescape #1576
DPL-823 [Limber part] Import PBMC pool plates into Sequencescape #1576
Conversation
…n sample manifests in Sequencescape
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1576 +/- ##
==========================================
Coverage ? 90.65%
==========================================
Files ? 354
Lines ? 7276
Branches ? 0
==========================================
Hits ? 6596
Misses ? 680
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Code Climate has analyzed commit ea55ebc and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 90.1% (0.0% change). View more on Code Climate. |
@@ -26,7 +26,8 @@ LRC PBMC Pools: | |||
# This plate has come from faculty and is entering the SeqOps pipeline for the first time here. | |||
LRC PBMC Pools Input: | |||
:asset_type: plate | |||
:stock_plate: false | |||
# stock_plate has to be true so that it appears in the 'Purpose' list when generating a sample manifest in Sequencescape | |||
:stock_plate: true | |||
:input_plate: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was comparing this to Bioscan Lysate plate and it is similar there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for checking
Main changes for this story are in Sequencescape - sanger/sequencescape#4017
Changes proposed in this pull request
When deploying to UAT, ssh onto Sequencescape server and run in Rails console:
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main
]- Check story numbers included
- Check for debug code
- Check version