Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified the platforms to force ruby #891

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

stevieing
Copy link
Contributor

@stevieing stevieing commented Jan 9, 2025

Closes #

Changes proposed in this pull request

  • Modified the platforms to force ruby. This means that gems will be compiled rather than use binaries. Although ci will take longer to run and it may take longer to deploy it should fix issues with native dependencies without binaries for newer ruby versions.

Instructions for Reviewers

I based this decision on the fact that traction service uses this strategy and has no issues and is more resilient to changes.

I will deploy from branch to ensure it works correctly before commiting to develop.

I have used the following commands:

bundle lock --add-platform ruby
bundle config force_ruby_platform true

The next stage will be to upgrade to rails 7.2.

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version
bundle lock --add-platform ruby
bundle config force_ruby_platform true

@stevieing stevieing requested review from BenTopping and yoldas January 9, 2025 09:08
@stevieing stevieing self-assigned this Jan 9, 2025
Copy link
Member

@yoldas yoldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this will be useful if binaries for the dependencies are not available for the ruby version used but because it is compiling from sources, is there a possibility that compilation for a dependency fails on CI or during deployment?

I am assuming it should be OK

  • it was tried before
  • given that we use the same machine configurations for different environments to test deployment before production
  • it will be the same during the periods between ruby version changes.

@stevieing
Copy link
Contributor Author

Yes, this will be useful if binaries for the dependencies are not available for the ruby version used but because it is compiling from sources, is there a possibility that compilation for a dependency fails on CI or during deployment?

I am assuming it should be OK

* it was tried before

* given that we use the same machine configurations for different environments to test deployment before production

* it will be the same during the periods between ruby version changes.

Thanks. traction-service has been using this strategy from it's inception so it is working well.

I deployed from branch today and it worked.

@stevieing stevieing removed the request for review from BenTopping January 9, 2025 15:43
@stevieing stevieing merged commit 80def9d into develop Jan 9, 2025
7 checks passed
@stevieing stevieing deleted the force-ruby-platform branch January 9, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants