Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ui for baracoda cog uk id #87

Merged
merged 4 commits into from
Feb 4, 2021
Merged

Ui for baracoda cog uk id #87

merged 4 commits into from
Feb 4, 2021

Conversation

emrojo
Copy link
Contributor

@emrojo emrojo commented Feb 4, 2021

Closes #

Changes proposed in this pull request:

  • ...

@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #87 (55af741) into develop (2c2f1b8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #87   +/-   ##
========================================
  Coverage    82.30%   82.30%           
========================================
  Files           10       10           
  Lines          226      226           
  Branches        20       20           
========================================
  Hits           186      186           
  Misses          35       35           
  Partials         5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c2f1b8...55af741. Read the comment docs.

@emrojo emrojo marked this pull request as ready for review February 4, 2021 10:54
pjvv
pjvv previously approved these changes Feb 4, 2021
baracoda/static/index.html Show resolved Hide resolved
}
}
</script>
<h1>Baracoda COG UK id retriever</h1>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would call it "COG-UK barcode creator"

<label for="prefix">Prefix
<select id="prefix"></select>
</label>
<label for="count">Count
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would call it "Number" for "number of barcodes".

</label>
<label for="count">Count
<input type="text" name="count" id="count" value="" autocomplete="off" /></label>
<input type="button" name="but" onclick="clickButton()" value="Retrieve" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say "Create".

@emrojo emrojo merged commit e72b012 into develop Feb 4, 2021
@emrojo emrojo deleted the ui_for_cogukid_retrieve branch February 4, 2021 12:18
@emrojo emrojo linked an issue Feb 4, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG - small ui/script to temporarily create COG UK ids
2 participants