Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email jwt timeout #640

Merged
merged 6 commits into from
Nov 2, 2023
Merged

Email jwt timeout #640

merged 6 commits into from
Nov 2, 2023

Conversation

yijen-sun
Copy link
Contributor

Description

Set a timeout on confirmation links sent out in emails, so that they expire after 15 minutes. Fixed the JWT token to expire after a day, as well.

Closes #556

Changes to .env file, please make sure your copy of it is changed as well!

Type of change

Please tick the boxes that best match your changes.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This requires a run of yarn install
  • This has migration changes and requires a run of yarn dev:migration:run

How Has This Been Tested?

Please describe how you tested this PR (both manually and with tests) Provide instructions so we can reproduce.

  • Manually tested -- you can create a new account and wait 15 minutes before clicking on the confirmation link. The confirmation should not go through!

Checklist:

  • I have run the production builds in docker for the frontend/backend and ensure things run fine. Check README of repo on how to run if not sure.
  • I have performed a self-review of my own code
  • I have commented my code where needed
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I've run the end to end tests
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@daisykucharski daisykucharski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think we're good to merge this! However, a good idea for a future ticket would be to make the error more clear (i.e. why is this not a valid confirmation email) and maybe redirect to a page where they can resend the verification email

@yijen-sun yijen-sun merged commit 51fe366 into main Nov 2, 2023
4 checks passed
@yijen-sun yijen-sun deleted the email-jwt-timeout branch November 2, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable Old Email Confirmation JWT Token
2 participants