Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update folder name from api-v2 -> api and frontend-v2 -> frontend #638

Closed
wants to merge 2 commits into from

Conversation

BrandonLim8890
Copy link
Contributor

Description

The nastiest and largest change where all I'm doing is just renaming all folder with v2's to regular names. This now means that to run the app, we can't do dev:v2 and instead we just use dev

Type of change

Please tick the boxes that best match your changes.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This requires a run of yarn install
  • This has migration changes and requires a run of yarn dev:migration:run

How Has This Been Tested?

Tested all changes locally!

Checklist:

  • I have run the production builds in docker for the frontend/backend and ensure things run fine. Check README of repo on how to run if not sure.
  • I have performed a self-review of my own code
  • I have commented my code where needed
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@BrandonLim8890 BrandonLim8890 force-pushed the blim/update-folder-names branch from 939fc52 to f67d201 Compare October 22, 2023 19:50
@BrandonLim8890 BrandonLim8890 deleted the blim/update-folder-names branch January 24, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant