Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic header #26

Merged
merged 9 commits into from
Nov 24, 2024
Merged

Dynamic header #26

merged 9 commits into from
Nov 24, 2024

Conversation

owens1127
Copy link
Collaborator

@owens1127 owens1127 commented Nov 21, 2024 •
edited
Loading

Description

I made the header dynamic so authenticated users see different buttons than those who are logged out

Also updated the PR template a bit

Motivation and Context

Closes dynamic header

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Global styling changes
  • New package(s)
  • New dependencies
  • Project configuration
  • Environment variable update
  • Database migration
  • CI/CD changes (changing github actions or deployment scripts)

Checklist:

  • I verified my changes work in the local environment
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I verified my changes work in the preview environment

How has this been tested?

works on my machine

Screenshots (if appropriate):

Screenshot 2024-11-20 at 7 55 00 PM Screenshot 2024-11-20 at 7 54 50 PM

@vercel Vercel
Copy link

vercel bot commented Nov 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
good-dog-licensing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 24, 2024 8:18pm

@owens1127 owens1127 marked this pull request as ready for review November 21, 2024 02:18
ispapa
ispapa approved these changes Nov 24, 2024
View reviewed changes
Copy link
Collaborator

@ispapa ispapa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! jk just change profile to account

@owens1127 owens1127 merged commit 06b24ab into main Nov 24, 2024
7 checks passed
@owens1127 owens1127 deleted the dynamic-header branch November 24, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ispapa ispapa ispapa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@owens1127 @ispapa