Auth User Middleware #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
owens1127
requested changes
Oct 20, 2024
| }); | ||
|
|
||
| // Delete the records created for these tests | ||
| afterAll(async () => { |
There was a problem hiding this comment.
You can wrap this in a Promise.all() to parallelize the requests
| import { authenticatedProcedureBuilder } from "../internal/init"; | ||
|
|
||
| export const getAuthenticatedUserProcedure = | ||
| authenticatedProcedureBuilder.query(({ ctx }) => { |
There was a problem hiding this comment.
Let's
- Verify that this endpoint doesn't return the user's password
- Write a test specifically for that behavior
… sure password isn't returned
owens1127
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Closes story
Screenshots (if appropriate):
Types of changes
Checklist:
How has this been tested?