Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Post routes for sign up/in/out #10

Merged
merged 29 commits into from
Oct 20, 2024
Merged

Create Post routes for sign up/in/out #10

merged 29 commits into from
Oct 20, 2024

Conversation

tracyyh
Copy link
Contributor

@tracyyh tracyyh commented Oct 6, 2024 •
edited
Loading

Description

Create a new “auth” package

Create sign up, sign in, sign out tRPC procedures

Write tests for routes

Motivation and Context

Closes story

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • CI/CD changes (changing github actions or deployment scripts)
  • New package(s)
  • New dependencies
  • Global style changes
  • Project configuration

Checklist:

  • I verified my changes work in the local environment
  • I verified my changes work in the preview environment
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

How has this been tested?

made tests for each new route
Ran bun test

@vercel Vercel
Copy link

vercel bot commented Oct 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
good-dog-licensing-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2024 6:29pm

@tracyyh tracyyh marked this pull request as ready for review October 17, 2024 19:27
ispapa
ispapa reviewed Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@ispapa ispapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment otherwise looks good!

@tracyyh tracyyh requested a review from ispapa October 20, 2024 18:32
@tracyyh tracyyh merged commit 8db5d1b into main Oct 20, 2024
7 checks passed
@tracyyh tracyyh deleted the post-routes branch October 20, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owens1127 owens1127 owens1127 approved these changes

@DamianUduevbo DamianUduevbo Awaiting requested review from DamianUduevbo

@ispapa ispapa Awaiting requested review from ispapa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tracyyh @owens1127 @ispapa @DamianUduevbo