Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

count only active term notifications #245

Merged
merged 3 commits into from
Nov 19, 2024
Merged

count only active term notifications #245

merged 3 commits into from
Nov 19, 2024

Conversation

mehallhm
Copy link
Contributor

@mehallhm mehallhm commented Nov 19, 2024 •
edited by elvincheng3
Loading

Count only active term notifications to unblock users from being unable to sub/unsub to notifications because of subscriptions created in prior semesters.

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 80.017% (-0.2%) from 80.173%
when pulling 541a386 on active-notifs
into a5d14a0 on master.

@ananyaspatil ananyaspatil self-requested a review November 19, 2024 22:25
@mehallhm mehallhm merged commit e05fc90 into master Nov 19, 2024
8 of 10 checks passed
@mehallhm mehallhm deleted the active-notifs branch November 19, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elvincheng3 elvincheng3 elvincheng3 approved these changes

@ananyaspatil ananyaspatil Awaiting requested review from ananyaspatil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mehallhm @coveralls @elvincheng3