-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor serializers #220
Refactor serializers #220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating line 82 in the serializers/courseSerializer.ts breaks references in graphql/resolvers/class.ts. Updating the later to use the new static implementation of the method should clear the CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any existing tests for the serializers? If so, we should update/add to them for new code changes; if not, we should write tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any existing tests for the serializers? If so, we should update/add to them for new code changes; if not, we should write tests.
Purpose
Lodash is unnecessary and can be replaced by native features. Serializer methods are better suited as static methods.
Tickets
https://github.com/orgs/sandboxnu/projects/20?pane=issue&itemId=80651976
Contributors
@Anzhuo-W , @nickpfeiffer05
Feature List
searcher.ts
Reviewers
Primary:
@ananyaspatil
Secondary:
@mehallhm , @cherman23