Scrape professors in an additional request

infrastructure/dev/docker-compose-server.yml

@@ -9,8 +9,9 @@ services:
       - ./docker-postgresql-multiple-databases:/docker-entrypoint-initdb.d
       - pg:/var/lib/postgresql/data
     environment:
-      - POSTGRES_MULTIPLE_DATABASES=searchneu_dev,searchneu_test
-      - POSTGRES_USER=postgres
+      POSTGRES_MULTIPLE_DATABASES: searchneu_dev,searchneu_test
+      POSTGRES_USER: postgres
+      POSTGRES_PASSWORD: default_password
   es:
     image: docker.elastic.co/elasticsearch/elasticsearch-oss:7.10.2
     ports:
@@ -22,12 +23,12 @@ services:
     depends_on:
       - es
       - postgresql
-    command: yarn prod
     ports:
       - 4000:4000
       - 8080:8080
     environment:
-      DATABASE_URL: postgresql://postgres@postgresql:5432/searchneu_dev
+      DATABASE_URL: postgresql://postgres:default_password@postgresql:5432/searchneu_dev
+      POSTGRES_PASSWORD: default_password
       elasticURL: http://es:9200
       TWILIO_PHONE_NUMBER:
       TWILIO_ACCOUNT_SID:
@@ -36,5 +37,6 @@ services:
       CLIENT_ORIGIN: http://localhost:5000
       JWT_SECRET:
       SLACK_WEBHOOK_URL:
+
 volumes:
   pg:

package.json

@@ -67,7 +67,7 @@
     "@babel/node": "^7.0.0",
     "@babel/register": "^7.0.0",
     "@elastic/elasticsearch": "7.17.0",
-    "@prisma/client": "^5.0.0",
+    "@prisma/client": "5.22.0",
     "@typescript-eslint/typescript-estree": "^8.10.0",
     "amplitude": "^6.0.0",
     "apollo-server": "^3.13.0",

scrapers/classes/parsersxe/termParser.ts

@@ -203,10 +203,31 @@ class TermParser {
         );
 
         const bodyObj = JSON.parse(req.body);
-        if (bodyObj.success) {
-          return { items: bodyObj.data, totalCount: bodyObj.totalCount };
+
+        if (!bodyObj.success) {
+          return false;
         }
-        return false;
+
+        bodyObj.data = await Promise.all(
+          bodyObj.data.map(async (sr: SectionSR) => {
+            const resp = await request.get(
+              "https://nubanner.neu.edu/StudentRegistrationSsb/ssb/searchResults/getFacultyMeetingTimes",
+              {
+                searchParams: {
+                  term: termId,
+                  courseReferenceNumber: sr.courseReferenceNumber,
+                },
+              },
+            );
+
+            const body = await JSON.parse(resp.body);
+            sr.faculty = body.fmt[0]?.faculty ?? [];
+
+            return sr;
+          }),
+        );
+
+        return { items: bodyObj.data, totalCount: bodyObj.totalCount };
       })) as SectionSR[];
     } catch (error) {
       macros.error(`Could not get section data for ${termId}`);

services/dumpProcessor.ts

@@ -42,7 +42,6 @@ class DumpProcessor {
       convertSectionToPrismaType(section),
     );
     await this.saveSectionsToDatabase(processedSections);
-    await this.updateSectionsLastUpdateTime(termDump.sections);
 
     await this.saveSubjectsToDatabase(termDump.subjects);
 
@@ -131,7 +130,10 @@ class DumpProcessor {
 
     for (const sections of groupedSections) {
       const upsertQueries = sections.map((prismaSection) => {
+        // Updates thelast update time for tracking sections that haven't been updated
+        // in a while for eventual removal
         prismaSection.lastUpdateTime = updateTime;
+
         return prisma.section.upsert({
           create: prismaSection,
           update: prismaSection,
@@ -148,20 +150,6 @@ class DumpProcessor {
     macros.log("Finished with sections");
   }
 
-  /**
-   * Update the lastUpdateTime attribute on all given sections.
-   * We use this to track sections that haven't been updated in a while,
-   * which means that they're no longer on Banner & should be removed from our database.
-   */
-  async updateSectionsLastUpdateTime(sections: Section[]): Promise<void> {
-    await prisma.course.updateMany({
-      where: { id: { in: sections.map((s) => keys.getClassHash(s)) } },
-      data: { lastUpdateTime: new Date() },
-    });
-
-    macros.log("Finished updating times");
-  }
-
   /**
    * Saves all subject data to the database. This does NOT delete existing subjects, but will
    * overwrite the data if there is any new data for those subjects.