Backend rewrite #13
Merged
Backend rewrite #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ross3102
commented
Dec 4, 2022
•
ross3102
commented
- Rewrite the API to use typescript, typegoose, and type-graphql
- Reorganize the file structure
- Set up Jest for API integration tests (unit tests need to be looked into a bit more, https://typegraphql.com/docs/dependency-injection.html might be helpful)
- added --extensions ".ts" to start script (not sure if that has any effect)
…ts weird and tests are ehhh tho
…not know what to type things except as any
…not know what to type things except as any v2
…read up on this) + update package.json
…-API into switch-to-ts
…'s going on with createReadStream..... so yeah
clue4
reviewed
Dec 4, 2022
|
there seem to be A LOT of todo comments / code commented out -- i'm gonna make the decision and say that we can leave them in this PR for now, and I've made a new issue #14 for me to look at over winter ish break (do i even have a winter break??? ;-;) |
clue4
approved these changes
Dec 4, 2022
There was a problem hiding this comment.
see above comment -- there are some comments / potential todos for documentation still left in the codebase, but because they are minor, will approve this PR. Have also made an additional ticket for some cleanup/abstractions that we weren't able to get to in this semester for me to look at later!
note: while simultaneously testing and reviewing, we realized we had another bug, which has since been resolved --
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.