Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes in stubs and linker.py for Authentic Execution #36
Changes in stubs and linker.py for Authentic Execution #36
Changes from 1 commit
d58d972
ec7dbee
c05544c
62d2bf3
1b1f009
967f06a
588605d
2fc4ce6
7d29fb2
0554693
bb6edf2
09f2bfd
6152f0e
6f8cb87
e8f5890
3ae4774
ce71396
5621e27
16ae05c
b50bb02
0a81ca0
7ee6635
e5cb9ce
e760cea
537c3a0
b27b130
d57b76d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be wrong to free the memory if the buffer is inside the SM, right?
Also, should we just raise an error if this happens (how?) instead of continuing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes shouldn't free (although free is outside the enclave anyway).
the current
continue
seems fine, but indeed since it's really wrong, I'd simplyreturn
here. And maybe add a return value instead ofvoid
so you can return an error code as with the other functions?