Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fix add test for slider #84

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix fix add test for slider #84

wants to merge 2 commits into from

Conversation

ZanBin
Copy link
Contributor

@ZanBin ZanBin commented Dec 15, 2023

Summary

Features

Bugs

Check List

  • Your code builds clean without any errors or warnings.
  • Check coding convention.
  • Updated Storybook components and stories to reflect any changes made to the UI.
  • Test covers all edge cases and coverage is greater than or equal to 80%.

Proof of Completeness

Screenshot changes introduced

OR Video link

loc-nguyenthien
loc-nguyenthien reviewed Dec 15, 2023
View reviewed changes
src/components/Slider/Slider.tsx
}),
[progress],
[progress, value],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we need to add this value?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loc-nguyenthien loc-nguyenthien loc-nguyenthien left review comments

@honghoangsts honghoangsts Awaiting requested review from honghoangsts honghoangsts is a code owner

@baonguyenhsts baonguyenhsts Awaiting requested review from baonguyenhsts baonguyenhsts is a code owner

@hoangSTS hoangSTS Awaiting requested review from hoangSTS hoangSTS is a code owner

@huydosgtech huydosgtech Awaiting requested review from huydosgtech huydosgtech is a code owner

@loido loido Awaiting requested review from loido loido is a code owner

@ThinhKimVo ThinhKimVo Awaiting requested review from ThinhKimVo ThinhKimVo is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZanBin @loc-nguyenthien