feat: countdown component #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZanBin
requested review from
honghoangsts,
baonguyenhsts,
hoangSTS,
huydosgtech,
loc-nguyenthien,
loido and
ThinhKimVo
as code owners
ledutu2
reviewed
Nov 17, 2023
loc-nguyenthien
requested changes
Nov 17, 2023
honghoangsts
requested changes
Nov 17, 2023
loc-nguyenthien
changed the title
ZanBin
force-pushed
the
feature/countdown-component
branch
from
6e6ec76 to
5c8eef5
Compare
baonguyenhsts
requested changes
Nov 21, 2023
ZanBin
force-pushed
the
feature/countdown-component
branch
from
2bf7e3c to
dcbd740
Compare
| /* | ||
| caculate minutes | ||
| */ | ||
| const resultCaculatMinute = Math.floor(seconds / numberSecondPerMinute) % numberSecondPerMinute |
There was a problem hiding this comment.
wrong typo
Suggested change
| const resultCaculatMinute = Math.floor(seconds / numberSecondPerMinute) % numberSecondPerMinute | |
| const resultCaculateMinute = Math.floor(seconds / numberSecondPerMinute) % numberSecondPerMinute |
| caculate minutes | ||
| */ | ||
| const resultCaculatMinute = Math.floor(seconds / numberSecondPerMinute) % numberSecondPerMinute | ||
| const minute = resultCaculatMinute >= 0 ? resultCaculatMinute : 0 |
There was a problem hiding this comment.
why it need to be >= 0 ? shouldn't it be only > 0
if resultCaculateMinute = 0, it will be same as the value return from else condition
| caculate seconds | ||
| */ | ||
| const resultCaculatSecond = Math.round(seconds % numberSecondPerMinute) | ||
| const second = resultCaculatSecond >= 0 ? resultCaculatSecond : 0 |
There was a problem hiding this comment.
same with const minute
| */ | ||
| if (FormatTime.ddhhmmss === FormatTime[format]) { | ||
| const resultCaculatDay = Math.floor(seconds / secondPerDay) | ||
| const day = resultCaculatDay >= 0 ? resultCaculatDay : 0 |
|
|
||
| return ( | ||
| <Container style={[CountDownTheme.containerStyle, containerStyle]}> | ||
| {textDay && textDay} |
There was a problem hiding this comment.
should it convert to Boolean, because textDay has case = null, so if it return null it will return error string outside Text component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Features
Bugs
Check List
Proof of Completeness