Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerize the CLI #27

Merged
merged 7 commits into from
Oct 9, 2024
Merged

Dockerize the CLI #27

merged 7 commits into from
Oct 9, 2024

Conversation

artfuldev
Copy link
Contributor

Fixes #10

In this PR, we expose a docker image for the CLI. In addition, we update the documentation.

@artfuldev artfuldev requested a review from akshaykarle October 9, 2024 11:04
@artfuldev
Copy link
Contributor Author

We're kind of blocked on this.

The package is at: https://github.com/sahajsoft/pii-detection-and-anonymizer/pkgs/container/pii

However, it's private and can't be accessed by public. Logging into GHCR needs to be documented at the very least.

@artfuldev artfuldev marked this pull request as draft October 9, 2024 11:34
@akshaykarle
Copy link
Member

We're kind of blocked on this.

The package is at: https://github.com/sahajsoft/pii-detection-and-anonymizer/pkgs/container/pii

However, it's private and can't be accessed by public. Logging into GHCR needs to be documented at the very least.

Logging into the container registry seems to work for me: https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry#authenticating-with-a-personal-access-token-classic. We could document this and use it.

However, the container image is huge atm (>3g) might be good to have a better packaging mechanism and then just using that package instead of having to package poetry, python, etc as well in the current Dockerfile

@artfuldev artfuldev marked this pull request as ready for review October 9, 2024 15:47
@artfuldev artfuldev merged commit a75efc1 into main Oct 9, 2024
1 check passed
@artfuldev artfuldev deleted the dockerize-the-cli branch October 9, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dockerize
2 participants