Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: create new outreach campaign targeting all safes [SW-638] #4672

Merged
merged 6 commits into from
Dec 19, 2024

Conversation

jmealy
Copy link
Contributor

@jmealy jmealy commented Dec 16, 2024

What it solves

Resolves: https://www.notion.so/safe-global/76f265123c0a4ad680947ce489804342?v=f9f164524ec4464286fdc38f31589d0c&p=1528180fe57380d8889de953b3fa0a66&pm=s

How this PR fixes it

  • adds new active outreach with a link to the new survey in typeform
  • passes safe address, signer address, and chain id to the form to be recorded with the answers.

How to test it

  • Open a safe. The outreach popup should be shown.
  • clicking the CTA should open the survey in typeform. Upon finishing the survey, check that the safe addreess, signer address, and chain ID are included in the answers.
  • After clicking through to the survey, the popup should not be shown for that safe/signer combination again.

Screenshots

image

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Dec 16, 2024

Branch preview

⏳ Deploying a preview site...

Copy link

Implement UI elements

Copy link

github-actions bot commented Dec 16, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

github-actions bot commented Dec 16, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
74.07% (+0.01% 🔼)
14474/19541
🔴 Branches
51.71% (+0.01% 🔼)
3450/6672
🔴 Functions 57.13% 2056/3599
🟡 Lines
75.6% (+0% 🔼)
13126/17363
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / useShowOutreachPopup.tsx
100%
90% (-10% 🔻)
100% 100%

Test suite run success

1729 tests passing in 236 suites.

Report generated by 🧪jest coverage report action from c90b87f

@jmealy jmealy requested a review from katspaugh December 19, 2024 11:04
@jmealy jmealy marked this pull request as ready for review December 19, 2024 11:04
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intentional that this new picture is so big? Also did you run it through tinypng.com?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, made it smaller now 👍

@katspaugh
Copy link
Member

@liliya-soroka @francovenica I'll merge this to dev, please test on there.

@katspaugh katspaugh merged commit 9a20297 into dev Dec 19, 2024
8 of 14 checks passed
@katspaugh katspaugh deleted the micro-targeted-messages branch December 19, 2024 15:08
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2024
@liliya-soroka
Copy link
Member

Verified

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants