Feat: decode execTransaction SafeTransactions #4449

schmanu · 2024-10-30T12:07:05Z

What this PR changes

Properly decodes the child transaction when a parent Safe is calling execTransaction

How to test it

execute a signed Safe Transaction with another Safe

Screenshots

tbd

Checklist

I've tested the branch on mobile 📱
I've documented how it affects the analytics (if at all) 📊
I've written a unit/e2e test for it (if applicable) 🧑‍💻

This commit adds a new component called ExecTransaction, which is used in the TxData component to display nested transaction details.

… with `getConfirmationView`

github-actions · 2024-10-30T12:07:19Z

Branch preview

✅ Deploy successful!

Website:
https://feat_decode_exec_transaction--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook:
https://feat_decode_exec_transaction--walletweb.review.5afe.dev/storybook/

notion-workspace · 2024-10-30T12:08:44Z

Decode nested executeTransaction transactions

github-actions · 2024-10-30T12:13:42Z

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page	Size (compressed)
`global`	`998.99 KB` (🟢 -12.74 KB)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Eighteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load
`/apps`	`48.42 KB` (-1 B)	1.02 MB
`/apps/custom`	`40.06 KB` (-1 B)	1.01 MB
`/balances`	`29.44 KB` (🟢 -8.83 KB)	1 MB
`/balances/nfts`	`19.21 KB` (🟡 +1 B)	1018.2 KB
`/home`	`57.33 KB` (🟢 -2.18 KB)	1.03 MB
`/new-safe/advanced-create`	`36.68 KB` (🟡 +1.71 KB)	1.01 MB
`/new-safe/create`	`35.94 KB` (🟡 +1.71 KB)	1.01 MB
`/new-safe/load`	`16.61 KB` (🟡 +1.83 KB)	1015.6 KB
`/settings`	`451 B` (🟡 +1 B)	999.43 KB
`/settings/cookies`	`7.68 KB` (🟢 -1 B)	1006.67 KB
`/settings/data`	`7.58 KB` (🟢 -3 B)	1006.57 KB
`/settings/environment-variables`	`9.17 KB` (🟡 +3 B)	1008.16 KB
`/settings/modules`	`9.84 KB` (🟢 -3 B)	1008.83 KB
`/settings/notifications`	`27.05 KB` (-2 B)	1 MB
`/settings/setup`	`36 KB` (-2 B)	1.01 MB
`/transactions`	`73.69 KB` (🟡 +1 B)	1.05 MB
`/transactions/history`	`73.66 KB` (🟡 +1 B)	1.05 MB
`/transactions/queue`	`31.3 KB` (-2 B)	1.01 MB

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

github-actions · 2024-10-30T12:14:04Z

Coverage report

St.^❔	Category	Percentage	Covered / Total
🟡	Statements	73.63% (-0.03% 🔻)	13569/18429
🔴	Branches	51.21% (-0.1% 🔻)	3292/6429
🔴	Functions	57.08% (-0.11% 🔻)	1971/3453
🟡	Lines	75.33% (-0.03% 🔻)	12340/16381

Show new covered files 🐣

St.^❔	File	Statements	Branches	Functions	Lines
🟡	`...` / index.tsx	62.5%	0%	0%	65.22%
🟢	`...` / NestedTransaction.tsx	85.71%	0%	0%	100%
🔴	`...` / index.tsx	51.72%	0%	0%	53.57%

Show files with reduced coverage 🔻

St.^❔	File	Statements	Branches	Functions	Lines
🟢	`...` / useTxPendingStatuses.ts	83.64% (-0.91% 🔻)	68.33% (-1.67% 🔻)	75%	92.63% (-1.05% 🔻)

Test suite run success

1584 tests passing in 209 suites.

Report generated by 🧪jest coverage report action from f0739f0

src/components/transactions/TxDetails/TxData/ExecTransaction/index.tsx

iamacook · 2024-10-30T18:37:24Z

src/components/transactions/TxDetails/TxData/ExecTransaction/index.tsx

+
+  const [dataDecoded, error] = useAsync(async () => {
+    if (chain?.chainId && data?.to.value && childSafeTx) {
+      return await getConfirmationView(


Can we try getting this from the preview endpoint instead? We want to eventually deprecate the confirmation view.

I tried to change it quickly but the returned types are not fully compatible. So we need to adjust the component that renders the result.

Lets do it in a separate tech debt issue to reduce the scope.

src/components/transactions/TxDetails/TxData/ExecTransaction/index.tsx

src/components/transactions/TxDetails/TxData/index.tsx

src/hooks/useTransactionType.tsx

src/utils/transaction-guards.ts

…eat/decode-exec-transaction

tmjssz added 2 commits October 29, 2024 10:08

feat: Add ExecTransaction component for nested transactions

013b5d5

This commit adds a new component called ExecTransaction, which is used in the TxData component to display nested transaction details.

refactor: Decode nested transaction data in ExecTransaction component…

59c0f5a

… with `getConfirmationView`

schmanu changed the base branch from dev to feat/decode-approve-hash October 30, 2024 12:09

schmanu added 3 commits October 30, 2024 13:44

refactor: extract logic outside of component

5523e1d

test: transaction-guards.ts

430ec08

fix: improve decoding of nested transaction data

0fae9ec

schmanu requested a review from iamacook October 30, 2024 14:41

fix: use external links

66a7940

iamacook reviewed Oct 30, 2024

View reviewed changes

schmanu added 2 commits October 31, 2024 10:10

fix: review issues

09b0194

Merge remote-tracking branch 'origin/feat/decode-approve-hash' into f…

f0739f0

…eat/decode-exec-transaction

schmanu merged commit c589bff into feat/decode-approve-hash Oct 31, 2024
13 checks passed

schmanu deleted the feat/decode-exec-transaction branch October 31, 2024 12:49

github-actions bot locked and limited conversation to collaborators Oct 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat: decode execTransaction SafeTransactions #4449

Feat: decode execTransaction SafeTransactions #4449

schmanu commented Oct 30, 2024 •

edited

Loading

github-actions bot commented Oct 30, 2024 •

edited

Loading

notion-workspace bot commented Oct 30, 2024

github-actions bot commented Oct 30, 2024 •

edited

Loading

github-actions bot commented Oct 30, 2024 •

edited

Loading

iamacook Oct 30, 2024

schmanu Oct 31, 2024

Feat: decode execTransaction SafeTransactions #4449

Feat: decode execTransaction SafeTransactions #4449

Conversation

schmanu commented Oct 30, 2024 • edited Loading

What this PR changes

How to test it

Screenshots

Checklist

github-actions bot commented Oct 30, 2024 • edited Loading

Branch preview

notion-workspace bot commented Oct 30, 2024

github-actions bot commented Oct 30, 2024 • edited Loading

📦 Next.js Bundle Analysis for safe-wallet-web

🎉 Global Bundle Size Decreased

Eighteen Pages Changed Size

github-actions bot commented Oct 30, 2024 • edited Loading

Coverage report

Test suite run success

iamacook Oct 30, 2024

Choose a reason for hiding this comment

schmanu Oct 31, 2024

Choose a reason for hiding this comment

schmanu commented Oct 30, 2024 •

edited

Loading

github-actions bot commented Oct 30, 2024 •

edited

Loading

github-actions bot commented Oct 30, 2024 •

edited

Loading

github-actions bot commented Oct 30, 2024 •

edited

Loading